dir.c: clean the entire struct in clear_exclude_list()

pclouds · gitster · commit 2653a8c6fa04 · 2015-12-28T12:48:27.000-08:00
Make sure "el" can be reuseable again. The problem was el-&gt;alloc is
not cleared and may cause segfaults next time because add_exclude()
thinks el-&gt;excludes (being NULL) has enough space. Just clear the
entire struct to be safe.

Signed-off-by: Nguyễn Thái Ngọc Duy &lt;pclouds@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/dir.c b/dir.c
@@ -501,9 +501,7 @@ void clear_exclude_list(struct exclude_list *el)
 	free(el->excludes);
 	free(el->filebuf);
 
-	el->nr = 0;
-	el->excludes = NULL;
-	el->filebuf = NULL;
+	memset(el, 0, sizeof(*el));
 }
 
 static void trim_trailing_spaces(char *buf)

Original file line number	Diff line number	Diff line change
`@@ -501,9 +501,7 @@ void clear_exclude_list(struct exclude_list *el)`
`501`	`501`	`free(el->excludes);`
`502`	`502`	`free(el->filebuf);`
`503`	`503`
`504`		`- el->nr = 0;`
`505`		`- el->excludes = NULL;`
`506`		`- el->filebuf = NULL;`
	`504`	`+ memset(el, 0, sizeof(*el));`
`507`	`505`	`}`
`508`	`506`
`509`	`507`	`static void trim_trailing_spaces(char *buf)`