Skip to content

Commit 265ab48

Browse files
r1walzgitster
authored andcommitted
sequencer: use argv_array in reset_merge
Avoid using magic numbers for array size and index under `reset_merge` function. Use `argv_array` instead. This will make code shorter and easier to extend. Signed-off-by: Rohit Ashiwal <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 918d1e6 commit 265ab48

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

sequencer.c

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2734,13 +2734,18 @@ static int rollback_is_safe(void)
27342734

27352735
static int reset_merge(const struct object_id *oid)
27362736
{
2737-
const char *argv[4]; /* reset --merge <arg> + NULL */
2737+
int ret;
2738+
struct argv_array argv = ARGV_ARRAY_INIT;
27382739

2739-
argv[0] = "reset";
2740-
argv[1] = "--merge";
2741-
argv[2] = oid_to_hex(oid);
2742-
argv[3] = NULL;
2743-
return run_command_v_opt(argv, RUN_GIT_CMD);
2740+
argv_array_pushl(&argv, "reset", "--merge", NULL);
2741+
2742+
if (!is_null_oid(oid))
2743+
argv_array_push(&argv, oid_to_hex(oid));
2744+
2745+
ret = run_command_v_opt(argv.argv, RUN_GIT_CMD);
2746+
argv_array_clear(&argv);
2747+
2748+
return ret;
27442749
}
27452750

27462751
static int rollback_single_pick(struct repository *r)

0 commit comments

Comments
 (0)