Skip to content

Commit 26c3177

Browse files
René Scharfegitster
authored andcommitted
revision: factor out add_pending_sha1
This function is a combination of the static get_reference and add_pending_object. It can be used to easily queue objects by hash. Signed-off-by: Rene Scharfe <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 83933c9 commit 26c3177

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

revision.c

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,13 @@ static struct object *get_reference(struct rev_info *revs, const char *name, con
185185
return object;
186186
}
187187

188+
void add_pending_sha1(struct rev_info *revs, const char *name,
189+
const unsigned char *sha1, unsigned int flags)
190+
{
191+
struct object *object = get_reference(revs, name, sha1, flags);
192+
add_pending_object(revs, object, name);
193+
}
194+
188195
static struct commit *handle_commit(struct rev_info *revs, struct object *object, const char *name)
189196
{
190197
unsigned long flags = object->flags;
@@ -832,9 +839,7 @@ struct all_refs_cb {
832839
static int handle_one_ref(const char *path, const unsigned char *sha1, int flag, void *cb_data)
833840
{
834841
struct all_refs_cb *cb = cb_data;
835-
struct object *object = get_reference(cb->all_revs, path, sha1,
836-
cb->all_flags);
837-
add_pending_object(cb->all_revs, object, path);
842+
add_pending_sha1(cb->all_revs, path, sha1, cb->all_flags);
838843
return 0;
839844
}
840845

revision.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ extern void add_object(struct object *obj,
191191
const char *name);
192192

193193
extern void add_pending_object(struct rev_info *revs, struct object *obj, const char *name);
194+
extern void add_pending_sha1(struct rev_info *revs, const char *name, const unsigned char *sha1, unsigned int flags);
194195

195196
extern void add_head_to_pending(struct rev_info *);
196197

0 commit comments

Comments
 (0)