Skip to content

Commit 271940c

Browse files
committed
Merge branch 'es/want-color-fd-defensive'
Futureproofing a helper function that can easily be misused. * es/want-color-fd-defensive: color: protect against out-of-bounds reads and writes
2 parents d1b0164 + 65bb21e commit 271940c

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

color.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -343,6 +343,9 @@ int want_color_fd(int fd, int var)
343343

344344
static int want_auto[3] = { -1, -1, -1 };
345345

346+
if (fd < 1 || fd >= ARRAY_SIZE(want_auto))
347+
BUG("file descriptor out of range: %d", fd);
348+
346349
if (var < 0)
347350
var = git_use_color_default;
348351

0 commit comments

Comments
 (0)