Skip to content

Commit 2752af9

Browse files
kbleesdscho
authored andcommitted
Win32: implement basic symlink() functionality (file symlinks only)
Implement symlink() that always creates file symlinks. Fails with ENOSYS if symlinks are disabled or unsupported. Note: CreateSymbolicLinkW() was introduced with symlink support in Windows Vista. For compatibility with Windows XP, we need to load it dynamically and fail gracefully if it isnt's available. Signed-off-by: Karsten Blees <[email protected]>
1 parent d18741b commit 2752af9

File tree

2 files changed

+32
-2
lines changed

2 files changed

+32
-2
lines changed

compat/mingw.c

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,9 @@ static int retry_ask_yes_no(int *tries, const char *format, ...)
230230
return result;
231231
}
232232

233+
234+
DECLARE_PROC_ADDR(kernel32.dll, BOOL, CreateSymbolicLinkW, LPCWSTR, LPCWSTR, DWORD);
235+
233236
/* Normalizes NT paths as returned by some low-level APIs. */
234237
static wchar_t *normalize_ntpath(wchar_t *wbuf)
235238
{
@@ -2055,6 +2058,34 @@ int link(const char *oldpath, const char *newpath)
20552058
return 0;
20562059
}
20572060

2061+
int symlink(const char *target, const char *link)
2062+
{
2063+
wchar_t wtarget[MAX_LONG_PATH], wlink[MAX_LONG_PATH];
2064+
int len;
2065+
2066+
/* fail if symlinks are disabled or API is not supported (WinXP) */
2067+
if (!has_symlinks || !INIT_PROC_ADDR(CreateSymbolicLinkW)) {
2068+
errno = ENOSYS;
2069+
return -1;
2070+
}
2071+
2072+
if ((len = xutftowcs_long_path(wtarget, target)) < 0
2073+
|| xutftowcs_long_path(wlink, link) < 0)
2074+
return -1;
2075+
2076+
/* convert target dir separators to backslashes */
2077+
while (len--)
2078+
if (wtarget[len] == '/')
2079+
wtarget[len] = '\\';
2080+
2081+
/* create file symlink */
2082+
if (!CreateSymbolicLinkW(wlink, wtarget, 0)) {
2083+
errno = err_win_to_posix(GetLastError());
2084+
return -1;
2085+
}
2086+
return 0;
2087+
}
2088+
20582089
#ifndef _WINNT_H
20592090
/*
20602091
* The REPARSE_DATA_BUFFER structure is defined in the Windows DDK (in

compat/mingw.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,6 @@ struct utsname {
101101
* trivial stubs
102102
*/
103103

104-
static inline int symlink(const char *oldpath, const char *newpath)
105-
{ errno = ENOSYS; return -1; }
106104
static inline int fchmod(int fildes, mode_t mode)
107105
{ errno = ENOSYS; return -1; }
108106
#ifndef __MINGW64_VERSION_MAJOR
@@ -193,6 +191,7 @@ int setitimer(int type, struct itimerval *in, struct itimerval *out);
193191
int sigaction(int sig, struct sigaction *in, struct sigaction *out);
194192
int link(const char *oldpath, const char *newpath);
195193
int uname(struct utsname *buf);
194+
int symlink(const char *target, const char *link);
196195
int readlink(const char *path, char *buf, size_t bufsiz);
197196

198197
/*

0 commit comments

Comments
 (0)