Teach notes code to free its internal data structures on request

jherland · gitster · commit 27d57564102a · 2009-10-19T19:00:24.000-07:00
There's no need to be rude to memory-concious callers...

This patch has been improved by the following contributions:
- Junio C Hamano: avoid old-style declaration

Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
Signed-off-by: Johan Herland &lt;johan@herland.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/notes.c b/notes.c
@@ -105,6 +105,13 @@ static unsigned char *lookup_notes(const unsigned char *commit_sha1)
 	return hash_map.entries[index].notes_sha1;
 }
 
+void free_notes(void)
+{
+	free(hash_map.entries);
+	memset(&hash_map, 0, sizeof(struct hash_map));
+	initialized = 0;
+}
+
 void get_commit_notes(const struct commit *commit, struct strbuf *sb,
 		const char *output_encoding, int flags)
 {
diff --git a/notes.h b/notes.h
@@ -1,6 +1,9 @@
 #ifndef NOTES_H
 #define NOTES_H
 
+/* Free (and de-initialize) the internal notes tree structure */
+void free_notes(void);
+
 #define NOTES_SHOW_HEADER 1
 #define NOTES_INDENT 2
 

Original file line number	Diff line number	Diff line change
`@@ -105,6 +105,13 @@ static unsigned char lookup_notes(const unsigned char commit_sha1)`
`105`	`105`	`return hash_map.entries[index].notes_sha1;`
`106`	`106`	`}`
`107`	`107`
	`108`	`+void free_notes(void)`
	`109`	`+{`
	`110`	`+ free(hash_map.entries);`
	`111`	`+ memset(&hash_map, 0, sizeof(struct hash_map));`
	`112`	`+ initialized = 0;`
	`113`	`+}`
	`114`	`+`
`108`	`115`	`void get_commit_notes(const struct commit commit, struct strbuf sb,`
`109`	`116`	`const char *output_encoding, int flags)`
`110`	`117`	`{`