Skip to content

Commit 288fcb1

Browse files
jiangxingitster
authored andcommitted
t5516: fail to run in verbose mode
The test case "push with config push.useBitmap" of t5516 was introduced in commit 82f67ee (send-pack.c: add config push.useBitmaps, 2022-06-17). It won't work in verbose mode, e.g.: $ sh t5516-fetch-push.sh --run='1,115' -v This is because "git-push" will run in a tty in this case, and the subcommand "git pack-objects" will contain an argument "--progress" instead of "-q". Adding a specific option "--quiet" to "git push" will get a stable result for t5516. Signed-off-by: Jiang Xin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 82f67ee commit 288fcb1

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

t/t5516-fetch-push.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1870,19 +1870,19 @@ test_expect_success 'push with config push.useBitmaps' '
18701870
git checkout main &&
18711871
test_unconfig push.useBitmaps &&
18721872
GIT_TRACE2_EVENT="$PWD/default" \
1873-
git push testrepo main:test &&
1873+
git push --quiet testrepo main:test &&
18741874
test_subcommand git pack-objects --all-progress-implied --revs --stdout \
18751875
--thin --delta-base-offset -q <default &&
18761876
18771877
test_config push.useBitmaps true &&
18781878
GIT_TRACE2_EVENT="$PWD/true" \
1879-
git push testrepo main:test2 &&
1879+
git push --quiet testrepo main:test2 &&
18801880
test_subcommand git pack-objects --all-progress-implied --revs --stdout \
18811881
--thin --delta-base-offset -q <true &&
18821882
18831883
test_config push.useBitmaps false &&
18841884
GIT_TRACE2_EVENT="$PWD/false" \
1885-
git push testrepo main:test3 &&
1885+
git push --quiet testrepo main:test3 &&
18861886
test_subcommand git pack-objects --all-progress-implied --revs --stdout \
18871887
--thin --delta-base-offset -q --no-use-bitmap-index <false
18881888
'

0 commit comments

Comments
 (0)