use strbuf_addch for adding single characters

rscharfe · gitster · commit 294b2680cd89 · 2014-07-10T14:06:46.000-07:00
Signed-off-by: Rene Scharfe &lt;l.s.r@web.de&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/merge-recursive.c b/merge-recursive.c
@@ -171,7 +171,7 @@ static void output(struct merge_options *o, int v, const char *fmt, ...)
 	strbuf_vaddf(&o->obuf, fmt, ap);
 	va_end(ap);
 
-	strbuf_add(&o->obuf, "\n", 1);
+	strbuf_addch(&o->obuf, '\n');
 	if (!o->buffer_output)
 		flush_output(o);
 }
diff --git a/pathspec.c b/pathspec.c
@@ -338,7 +338,7 @@ static void NORETURN unsupported_magic(const char *pattern,
 		if (!(magic & m->bit))
 			continue;
 		if (sb.len)
-			strbuf_addstr(&sb, " ");
+			strbuf_addch(&sb, ' ');
 		if (short_magic & m->bit)
 			strbuf_addf(&sb, "'%c'", m->mnemonic);
 		else
diff --git a/url.c b/url.c
@@ -121,7 +121,7 @@ void end_url_with_slash(struct strbuf *buf, const char *url)
 {
 	strbuf_addstr(buf, url);
 	if (buf->len && buf->buf[buf->len - 1] != '/')
-		strbuf_addstr(buf, "/");
+		strbuf_addch(buf, '/');
 }
 
 void str_end_url_with_slash(const char *url, char **dest) {

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ static void output(struct merge_options o, int v, const char fmt, ...)`
`171`	`171`	`strbuf_vaddf(&o->obuf, fmt, ap);`
`172`	`172`	`va_end(ap);`
`173`	`173`
`174`		`- strbuf_add(&o->obuf, "\n", 1);`
	`174`	`+ strbuf_addch(&o->obuf, '\n');`
`175`	`175`	`if (!o->buffer_output)`
`176`	`176`	`flush_output(o);`
`177`	`177`	`}`
Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ void end_url_with_slash(struct strbuf buf, const char url)`
`121`	`121`	`{`
`122`	`122`	`strbuf_addstr(buf, url);`
`123`	`123`	`if (buf->len && buf->buf[buf->len - 1] != '/')`
`124`		`- strbuf_addstr(buf, "/");`
	`124`	`+ strbuf_addch(buf, '/');`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`void str_end_url_with_slash(const char url, char *dest) {`