Skip to content

Commit 296d673

Browse files
dschogitster
authored andcommitted
Mark win32's pthread_exit() as NORETURN
The pthread_exit() function is not expected to return. Ever. On Windows, we call ExitThread() whose documentation claims: "Ends the calling thread", i.e. there is no condition in which this function simply returns: https://msdn.microsoft.com/en-us/library/windows/desktop/ms682659 While at it, fix the return type to be void, as per http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_exit.html Pointed out by Jeff King, helped by Stefan Naewe, Junio Hamano & Johannes Sixt. Signed-off-by: Johannes Schindelin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 326e5bc commit 296d673

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

compat/win32/pthread.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ extern int win32_pthread_join(pthread_t *thread, void **value_ptr);
7575
#define pthread_equal(t1, t2) ((t1).tid == (t2).tid)
7676
extern pthread_t pthread_self(void);
7777

78-
static inline int pthread_exit(void *ret)
78+
static inline void NORETURN pthread_exit(void *ret)
7979
{
8080
ExitThread((DWORD)ret);
8181
}

0 commit comments

Comments
 (0)