Skip to content

Commit 29d7427

Browse files
committed
Merge branch 'ds/multi-pack-index'
The multi-pack-index left mmapped file descriptors open when it does not have to. * ds/multi-pack-index: multi-pack-index: close file descriptor after mmap
2 parents 6d56d4c + 6c7ff7c commit 29d7427

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

midx.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,9 @@ struct multi_pack_index *load_multi_pack_index(const char *object_dir, int local
7272
FREE_AND_NULL(midx_name);
7373

7474
midx_map = xmmap(NULL, midx_size, PROT_READ, MAP_PRIVATE, fd, 0);
75+
close(fd);
7576

7677
FLEX_ALLOC_STR(m, object_dir, object_dir);
77-
m->fd = fd;
7878
m->data = midx_map;
7979
m->data_len = midx_size;
8080
m->local = local;
@@ -190,8 +190,6 @@ void close_midx(struct multi_pack_index *m)
190190
return;
191191

192192
munmap((unsigned char *)m->data, m->data_len);
193-
close(m->fd);
194-
m->fd = -1;
195193

196194
for (i = 0; i < m->num_packs; i++) {
197195
if (m->packs[i])

midx.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ struct repository;
1212
struct multi_pack_index {
1313
struct multi_pack_index *next;
1414

15-
int fd;
16-
1715
const unsigned char *data;
1816
size_t data_len;
1917

0 commit comments

Comments
 (0)