mailinfo: remove a no-op call convert_to_utf8(it, "")

gitster · gitster · commit 2a5ce7cf0da8 · 2015-10-18T22:13:27.000-07:00
The called function checks if the second parameter is either a NULL
or an empty string at the very beginning and returns without doing
anything.  Remove the useless call.

Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/mailinfo.c b/builtin/mailinfo.c
@@ -612,11 +612,6 @@ static void decode_header(struct strbuf *it)
 {
 	if (decode_header_bq(it))
 		return;
-	/* otherwise "it" is a straight copy of the input.
-	 * This can be binary guck but there is no charset specified.
-	 */
-	if (metainfo_charset)
-		convert_to_utf8(it, "");
 }
 
 static void decode_transfer_encoding(struct strbuf *line)

Original file line number	Diff line number	Diff line change
`@@ -612,11 +612,6 @@ static void decode_header(struct strbuf *it)`
`612`	`612`	`{`
`613`	`613`	`if (decode_header_bq(it))`
`614`	`614`	`return;`
`615`		`- /* otherwise "it" is a straight copy of the input.`
`616`		`- * This can be binary guck but there is no charset specified.`
`617`		`- */`
`618`		`- if (metainfo_charset)`
`619`		`- convert_to_utf8(it, "");`
`620`	`615`	`}`
`621`	`616`
`622`	`617`	`static void decode_transfer_encoding(struct strbuf *line)`