Skip to content

Commit 2a6291e

Browse files
committed
Merge branch 'jk/maint-t1304-setfacl'
Works around a false test failure caused by a bug in ecryptofs. * jk/maint-t1304-setfacl: t1304: improve setfacl prerequisite setup
2 parents a88d7aa + a14ad10 commit 2a6291e

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

t/t1304-default-acl.sh

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,15 @@ umask 077
1414
# We need an arbitrary other user give permission to using ACLs. root
1515
# is a good candidate: exists on all unices, and it has permission
1616
# anyway, so we don't create a security hole running the testsuite.
17-
18-
setfacl_out="$(setfacl -m u:root:rwx . 2>&1)"
19-
setfacl_ret=$?
20-
21-
if test $setfacl_ret != 0
22-
then
23-
say "Unable to use setfacl (output: '$setfacl_out'; return code: '$setfacl_ret')"
24-
else
25-
test_set_prereq SETFACL
26-
fi
17+
test_expect_success 'checking for a working acl setup' '
18+
if setfacl -m d:m:rwx -m u:root:rwx . &&
19+
getfacl . | grep user:root:rwx &&
20+
touch should-have-readable-acl &&
21+
getfacl should-have-readable-acl | egrep "mask::?rw-"
22+
then
23+
test_set_prereq SETFACL
24+
fi
25+
'
2726

2827
if test -z "$LOGNAME"
2928
then

0 commit comments

Comments
 (0)