Skip to content

Commit 2cf489a

Browse files
derrickstoleegitster
authored andcommitted
multi-pack-index: store local property
A pack-file is 'local' if it is stored within the usual object directory. If it is stored in an alternate, it is non-local. Pack-files are stored using a 'pack_local' member in the packed_git struct. Add a similar 'local' member to the multi_pack_index struct and 'local' parameters to the methods that load and prepare multi- pack-indexes. Signed-off-by: Derrick Stolee <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 6d68e6a commit 2cf489a

File tree

4 files changed

+13
-10
lines changed

4 files changed

+13
-10
lines changed

midx.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ static char *get_midx_filename(const char *object_dir)
3737
return xstrfmt("%s/pack/multi-pack-index", object_dir);
3838
}
3939

40-
struct multi_pack_index *load_multi_pack_index(const char *object_dir)
40+
struct multi_pack_index *load_multi_pack_index(const char *object_dir, int local)
4141
{
4242
struct multi_pack_index *m = NULL;
4343
int fd;
@@ -73,6 +73,7 @@ struct multi_pack_index *load_multi_pack_index(const char *object_dir)
7373
m->fd = fd;
7474
m->data = midx_map;
7575
m->data_len = midx_size;
76+
m->local = local;
7677

7778
m->signature = get_be32(m->data);
7879
if (m->signature != MIDX_SIGNATURE) {
@@ -209,7 +210,7 @@ static int prepare_midx_pack(struct multi_pack_index *m, uint32_t pack_int_id)
209210
strbuf_addf(&pack_name, "%s/pack/%s", m->object_dir,
210211
m->pack_names[pack_int_id]);
211212

212-
m->packs[pack_int_id] = add_packed_git(pack_name.buf, pack_name.len, 1);
213+
m->packs[pack_int_id] = add_packed_git(pack_name.buf, pack_name.len, m->local);
213214
strbuf_release(&pack_name);
214215
return !m->packs[pack_int_id];
215216
}
@@ -318,7 +319,7 @@ int midx_contains_pack(struct multi_pack_index *m, const char *idx_name)
318319
return 0;
319320
}
320321

321-
int prepare_multi_pack_index_one(struct repository *r, const char *object_dir)
322+
int prepare_multi_pack_index_one(struct repository *r, const char *object_dir, int local)
322323
{
323324
struct multi_pack_index *m = r->objects->multi_pack_index;
324325
struct multi_pack_index *m_search;
@@ -332,7 +333,7 @@ int prepare_multi_pack_index_one(struct repository *r, const char *object_dir)
332333
if (!strcmp(object_dir, m_search->object_dir))
333334
return 1;
334335

335-
r->objects->multi_pack_index = load_multi_pack_index(object_dir);
336+
r->objects->multi_pack_index = load_multi_pack_index(object_dir, local);
336337

337338
if (r->objects->multi_pack_index) {
338339
r->objects->multi_pack_index->next = m;
@@ -746,7 +747,7 @@ int write_midx_file(const char *object_dir)
746747
midx_name);
747748
}
748749

749-
packs.m = load_multi_pack_index(object_dir);
750+
packs.m = load_multi_pack_index(object_dir, 1);
750751

751752
packs.nr = 0;
752753
packs.alloc_list = packs.m ? packs.m->num_packs : 16;

midx.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ struct multi_pack_index {
1818
uint32_t num_packs;
1919
uint32_t num_objects;
2020

21+
int local;
22+
2123
const unsigned char *chunk_pack_names;
2224
const uint32_t *chunk_oid_fanout;
2325
const unsigned char *chunk_oid_lookup;
@@ -29,14 +31,14 @@ struct multi_pack_index {
2931
char object_dir[FLEX_ARRAY];
3032
};
3133

32-
struct multi_pack_index *load_multi_pack_index(const char *object_dir);
34+
struct multi_pack_index *load_multi_pack_index(const char *object_dir, int local);
3335
int bsearch_midx(const struct object_id *oid, struct multi_pack_index *m, uint32_t *result);
3436
struct object_id *nth_midxed_object_oid(struct object_id *oid,
3537
struct multi_pack_index *m,
3638
uint32_t n);
3739
int fill_midx_entry(const struct object_id *oid, struct pack_entry *e, struct multi_pack_index *m);
3840
int midx_contains_pack(struct multi_pack_index *m, const char *idx_name);
39-
int prepare_multi_pack_index_one(struct repository *r, const char *object_dir);
41+
int prepare_multi_pack_index_one(struct repository *r, const char *object_dir, int local);
4042

4143
int write_midx_file(const char *object_dir);
4244
void clear_midx_file(const char *object_dir);

packfile.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -963,11 +963,11 @@ static void prepare_packed_git(struct repository *r)
963963

964964
if (r->objects->packed_git_initialized)
965965
return;
966-
prepare_multi_pack_index_one(r, r->objects->objectdir);
966+
prepare_multi_pack_index_one(r, r->objects->objectdir, 1);
967967
prepare_packed_git_one(r, r->objects->objectdir, 1);
968968
prepare_alt_odb(r);
969969
for (alt = r->objects->alt_odb_list; alt; alt = alt->next) {
970-
prepare_multi_pack_index_one(r, alt->path);
970+
prepare_multi_pack_index_one(r, alt->path, 0);
971971
prepare_packed_git_one(r, alt->path, 0);
972972
}
973973
rearrange_packed_git(r);

t/helper/test-read-midx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
static int read_midx_file(const char *object_dir)
88
{
99
uint32_t i;
10-
struct multi_pack_index *m = load_multi_pack_index(object_dir);
10+
struct multi_pack_index *m = load_multi_pack_index(object_dir, 1);
1111

1212
if (!m)
1313
return 1;

0 commit comments

Comments
 (0)