remote: check for superfluous arguments in 'git remote add'

Thomas Rast · gitster · commit 2d2e3d25595c · 2013-04-24T13:12:51.000-07:00
The 'git remote add' subcommand did not check for superfluous command
line arguments.  Make it so.

Signed-off-by: Thomas Rast &lt;trast@inf.ethz.ch&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/remote.c b/builtin/remote.c
@@ -178,7 +178,7 @@ static int add(int argc, const char **argv)
 	argc = parse_options(argc, argv, NULL, options, builtin_remote_add_usage,
 			     0);
 
-	if (argc < 2)
+	if (argc != 2)
 		usage_with_options(builtin_remote_add_usage, options);
 
 	if (mirror && master)
diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh
@@ -1020,7 +1020,7 @@ test_extra_arg () {
 	"
 }
 
-test_extra_arg -f add nick url
+test_extra_arg add nick url
 test_extra_arg rename origin newname
 test_extra_arg remove origin
 test_extra_arg set-head origin master

Original file line number	Diff line number	Diff line change
`@@ -1020,7 +1020,7 @@ test_extra_arg () {`
`1020`	`1020`	`"`
`1021`	`1021`	`}`
`1022`	`1022`
`1023`		`-test_extra_arg -f add nick url`
	`1023`	`+test_extra_arg add nick url`
`1024`	`1024`	`test_extra_arg rename origin newname`
`1025`	`1025`	`test_extra_arg remove origin`
`1026`	`1026`	`test_extra_arg set-head origin master`