Skip to content

Commit 317c176

Browse files
avargitster
authored andcommitted
mktag tests: don't redirect stderr to a file needlessly
Remove the redirection of stderr to "message" in the valid tag test. This pattern seems to have been copy/pasted from the failure case in 446c6fa (New tests and en-passant modifications to mktag., 2006-07-29). While I'm at it do the same for the "replace" tests. The tag creation I'm changing here seems to have been copy/pasted from the "mktag" tests to those tests in cc400f5 (mktag: call "check_sha1_signature" with the replacement sha1, 2009-01-23). Nobody examines the contents of the resulting "message" file, so the net result is that error messages cannot be seen in "sh t3800-mktag.sh -v" output. Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 0d35ccb commit 317c176

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

t/t3800-mktag.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ EOF
222222

223223
test_expect_success \
224224
'allow empty tag email' \
225-
'git mktag <tag.sig >.git/refs/tags/mytag 2>message'
225+
'git mktag <tag.sig >.git/refs/tags/mytag'
226226

227227
############################################################
228228
# 16. disallow spaces in tag email
@@ -350,7 +350,7 @@ EOF
350350

351351
test_expect_success \
352352
'create valid tag' \
353-
'git mktag <tag.sig >.git/refs/tags/mytag 2>message'
353+
'git mktag <tag.sig >.git/refs/tags/mytag'
354354

355355
############################################################
356356
# 25. check mytag

t/t6050-replace.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ tagger T A Gger <> 0 +0000
129129
EOF
130130

131131
test_expect_success 'tag replaced commit' '
132-
git mktag <tag.sig >.git/refs/tags/mytag 2>message
132+
git mktag <tag.sig >.git/refs/tags/mytag
133133
'
134134

135135
test_expect_success '"git fsck" works' '

0 commit comments

Comments
 (0)