Make git reflog expire honour core.sharedRepository.

MadCoder · gitster · commit 336d09daf288 · 2008-06-15T15:54:06.000-07:00
Signed-off-by: Pierre Habouzit &lt;madcoder@debian.org&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin-reflog.c b/builtin-reflog.c
@@ -307,6 +307,8 @@ static int expire_reflog(const char *ref, const unsigned char *sha1, int unused,
 			unlink(newlog_path);
 		} else if (cmd->updateref && commit_ref(lock)) {
 			status |= error("Couldn't set %s", lock->ref_name);
+		} else {
+			adjust_shared_perm(log_file);
 		}
 	}
 	free(newlog_path);
diff --git a/t/t1301-shared-repo.sh b/t/t1301-shared-repo.sh
@@ -83,4 +83,19 @@ do
 
 done
 
+test_expect_success 'git reflog expire honors core.sharedRepository' '
+	git config core.sharedRepository group &&
+	git reflog expire --all &&
+	actual="$(ls -l .git/logs/refs/heads/master)" &&
+	case "$actual" in
+	-rw-rw-*)
+		: happy
+		;;
+	*)
+		echo Ooops, .git/logs/refs/heads/master is not 0662 [$actual]
+		false
+		;;
+	esac
+'
+
 test_done

Original file line number	Diff line number	Diff line change
`@@ -307,6 +307,8 @@ static int expire_reflog(const char ref, const unsigned char sha1, int unused,`
`307`	`307`	`unlink(newlog_path);`
`308`	`308`	`} else if (cmd->updateref && commit_ref(lock)) {`
`309`	`309`	`status \|= error("Couldn't set %s", lock->ref_name);`
	`310`	`+ } else {`
	`311`	`+ adjust_shared_perm(log_file);`
`310`	`312`	`}`
`311`	`313`	`}`
`312`	`314`	`free(newlog_path);`