Skip to content

Commit 35166b1

Browse files
Denton-Lgitster
authored andcommitted
t2016: add a NEEDSWORK about the PERL prerequisite
Since the builtin add-p is used when $GIT_TEST_ADD_I_USE_BUILTIN is given, we should replace the PERL prerequisite with an ADD_I prerequisite which first checks if $GIT_TEST_ADD_I_USE_BUILTIN is defined before checking PERL.[0] Mark this in a NEEDSWORK so that it can be addressed at a later time. [0]: https://lore.kernel.org/git/[email protected]/ Signed-off-by: Denton Liu <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent f82a9e5 commit 35166b1

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

t/t2016-checkout-patch.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@ test_expect_success PERL 'setup' '
1818

1919
# note: bar sorts before dir/foo, so the first 'n' is always to skip 'bar'
2020

21+
# NEEDSWORK: Since the builtin add-p is used when $GIT_TEST_ADD_I_USE_BUILTIN
22+
# is given, we should replace the PERL prerequisite with an ADD_I prerequisite
23+
# which first checks if $GIT_TEST_ADD_I_USE_BUILTIN is defined before checking
24+
# PERL.
2125
test_expect_success PERL 'saying "n" does nothing' '
2226
set_and_save_state dir/foo work head &&
2327
test_write_lines n n | git checkout -p &&

0 commit comments

Comments
 (0)