Skip to content

Commit 3558f32

Browse files
Pete Wyckoffgitster
authored andcommitted
git-p4: Change p4 command invocation
Change p4 command invocation to avoid going through the shell. This allows names with spaces and wildcards to work. Signed-off-by: Pete Wyckoff <[email protected]> Signed-off-by: Vitor Antunes <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent c5665ef commit 3558f32

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

contrib/fast-import/git-p4

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1984,7 +1984,7 @@ class P4Sync(Command, P4UserMap):
19841984
def importChanges(self, changes):
19851985
cnt = 1
19861986
for change in changes:
1987-
description = p4Cmd("describe %s" % change)
1987+
description = p4Cmd(["describe", str(change)])
19881988
self.updateOptionDict(description)
19891989

19901990
if not self.silent:

0 commit comments

Comments
 (0)