Skip to content

Commit 358e94d

Browse files
committed
.gitattributes: remove misspelled no-op whitespace attribute
Ever since 14f9e12 (Define the project whitespace policy, 2008-02-10) added the whitespace rules to .gitattributes, we spelled the most general rule like so: * whitespace=!indent,trail,space in the top-level .gitattributes file. The intent of this line was described in the commit log message: - Unless otherwise specified, indent with SP that could be replaced with HT are not "bad". But SP before HT in the indent is "bad", and trailing whitespaces are "bad". It clearly wanted to disable indent-with-non-tab, so !indent is most likely a misspelt form of '-indent'. Because indent-with-non-tab has never been enabled by default, by luck this was not causing any ill effect. We could either remove "!indent", or spell it "-indent". The immediate effect would be the same. It would only start to make a difference when/if we enable indent-with-non-tab by default in future versions of Git. Let's take the former option to remove "!indent" from the list. We would feel the effect first-hand ourselves before anybody else if we ever decide to change the built-in default whitespace rules, which would be hidden from us if we decide to rewrite it to "-indent" instead. Signed-off-by: Junio C Hamano <[email protected]>
1 parent 54a3711 commit 358e94d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.gitattributes

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
* whitespace=!indent,trail,space
1+
* whitespace=trail,space
22
*.[ch] whitespace=indent,trail,space diff=cpp
33
*.sh whitespace=indent,trail,space text eol=lf
44
*.perl text eol=lf diff=perl

0 commit comments

Comments
 (0)