perf/fsmonitor: use test_must_be_empty helper

nipunn1313 · gitster · commit 36fa907d7a10 · 2020-11-30T13:51:43.000-08:00
Simplify test and make error messages more clear here. Per feedback from Junio in 33226af (t/perf/fsmonitor: improve error message if typoing hook name, 2020-10-26) Signed-off-by: Nipunn Koorapati <nipunn@dropbox.com> Acked-by: Derrick Stolee <dstolee@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/t/perf/p7519-fsmonitor.sh b/t/perf/p7519-fsmonitor.sh
@@ -129,8 +129,7 @@ setup_for_fsmonitor() {
 
 	git config core.fsmonitor "$INTEGRATION_SCRIPT" &&
 	git update-index --fsmonitor 2>error &&
-	cat error &&
-	[ ! -s error ] # ensure no silent error
+	test_must_be_empty error  # ensure no silent error
 }
 
 test_perf_w_drop_caches () {

Original file line number	Diff line number	Diff line change
`@@ -129,8 +129,7 @@ setup_for_fsmonitor() {`
`129`	`129`
`130`	`130`	`git config core.fsmonitor "$INTEGRATION_SCRIPT" &&`
`131`	`131`	`git update-index --fsmonitor 2>error &&`
`132`		`- cat error &&`
`133`		`- [ ! -s error ] # ensure no silent error`
	`132`	`+ test_must_be_empty error # ensure no silent error`
`134`	`133`	`}`
`135`	`134`
`136`	`135`	`test_perf_w_drop_caches () {`