Skip to content

Commit 37bae10

Browse files
committed
Merge branch 'maint'
* maint: branch: die explicitly why when calling "git branch [-a|-r] branchname". fast-import: Document author/committer/tagger name is optional SubmittingPatches: hints to know the status of a submitted patch.
2 parents 4cc4738 + 9bfff3a commit 37bae10

File tree

5 files changed

+37
-21
lines changed

5 files changed

+37
-21
lines changed

Documentation/SubmittingPatches

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,20 @@ from the list and queue it to 'pu', in order to make it easier for
279279
people play with it without having to pick up and apply the patch to
280280
their trees themselves.
281281

282+
------------------------------------------------
283+
Know the status of your patch after submission
284+
285+
* You can use Git itself to find out when your patch is merged in
286+
master. 'git pull --rebase' will automatically skip already-applied
287+
patches, and will let you know. This works only if you rebase on top
288+
of the branch in which your patch has been merged (i.e. it will not
289+
tell you if your patch is merged in pu if you rebase on top of
290+
master).
291+
292+
* Read the git mailing list, the maintainer regularly posts messages
293+
entitled "What's cooking in git.git" and "What's in git.git" giving
294+
the status of various proposed changes.
295+
282296
------------------------------------------------
283297
MUA specific hints
284298

Documentation/git-fast-import.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -311,8 +311,8 @@ change to the project.
311311
....
312312
'commit' SP <ref> LF
313313
mark?
314-
('author' SP <name> SP LT <email> GT SP <when> LF)?
315-
'committer' SP <name> SP LT <email> GT SP <when> LF
314+
('author' (SP <name>)? SP LT <email> GT SP <when> LF)?
315+
'committer' (SP <name>)? SP LT <email> GT SP <when> LF
316316
data
317317
('from' SP <committish> LF)?
318318
('merge' SP <committish> LF)?
@@ -657,7 +657,7 @@ lightweight (non-annotated) tags see the `reset` command below.
657657
....
658658
'tag' SP <name> LF
659659
'from' SP <committish> LF
660-
'tagger' SP <name> SP LT <email> GT SP <when> LF
660+
'tagger' (SP <name>)? SP LT <email> GT SP <when> LF
661661
data
662662
....
663663

builtin-branch.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -638,10 +638,12 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
638638
rename_branch(head, argv[0], rename > 1);
639639
else if (rename && (argc == 2))
640640
rename_branch(argv[0], argv[1], rename > 1);
641-
else if (argc <= 2)
641+
else if (argc <= 2) {
642+
if (kinds != REF_LOCAL_BRANCH)
643+
die("-a and -r options to 'git branch' do not make sense with a branch name");
642644
create_branch(head, argv[0], (argc == 2) ? argv[1] : head,
643645
force_create, reflog, track);
644-
else
646+
} else
645647
usage_with_options(builtin_branch_usage, options);
646648

647649
return 0;

fast-import.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ Format of STDIN stream:
1919
2020
new_commit ::= 'commit' sp ref_str lf
2121
mark?
22-
('author' sp name sp '<' email '>' sp when lf)?
23-
'committer' sp name sp '<' email '>' sp when lf
22+
('author' (sp name)? sp '<' email '>' sp when lf)?
23+
'committer' (sp name)? sp '<' email '>' sp when lf
2424
commit_msg
2525
('from' sp committish lf)?
2626
('merge' sp committish lf)*
@@ -47,7 +47,7 @@ Format of STDIN stream:
4747
4848
new_tag ::= 'tag' sp tag_str lf
4949
'from' sp committish lf
50-
('tagger' sp name sp '<' email '>' sp when lf)?
50+
('tagger' (sp name)? sp '<' email '>' sp when lf)?
5151
tag_msg;
5252
tag_msg ::= data;
5353

t/t5403-post-checkout-hook.sh

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,19 @@ test_description='Test the post-checkout hook.'
77
. ./test-lib.sh
88

99
test_expect_success setup '
10-
echo Data for commit0. >a &&
11-
echo Data for commit0. >b &&
12-
git update-index --add a &&
13-
git update-index --add b &&
14-
tree0=$(git write-tree) &&
15-
commit0=$(echo setup | git commit-tree $tree0) &&
16-
git update-ref refs/heads/master $commit0 &&
17-
git clone ./. clone1 &&
18-
git clone ./. clone2 &&
19-
GIT_DIR=clone2/.git git branch -a new2 &&
20-
echo Data for commit1. >clone2/b &&
21-
GIT_DIR=clone2/.git git add clone2/b &&
22-
GIT_DIR=clone2/.git git commit -m new2
10+
echo Data for commit0. >a &&
11+
echo Data for commit0. >b &&
12+
git update-index --add a &&
13+
git update-index --add b &&
14+
tree0=$(git write-tree) &&
15+
commit0=$(echo setup | git commit-tree $tree0) &&
16+
git update-ref refs/heads/master $commit0 &&
17+
git clone ./. clone1 &&
18+
git clone ./. clone2 &&
19+
GIT_DIR=clone2/.git git branch new2 &&
20+
echo Data for commit1. >clone2/b &&
21+
GIT_DIR=clone2/.git git add clone2/b &&
22+
GIT_DIR=clone2/.git git commit -m new2
2323
'
2424

2525
for clone in 1 2; do

0 commit comments

Comments
 (0)