Skip to content

Commit 38a44bc

Browse files
Martin von Zweigbergkgitster
authored andcommitted
cherry: don't set ignored rev_info options
Ever since cherry was built-in in e827633 (Built-in cherry, 2006-10-24), it has set a bunch of options on the the rev_info that are only used while outputting a patch. But since the built-in cherry command never needs to output any patch (it uses add_commit_patch_id and has_commit_patch_id instead), these options are just distractions, so remove them. Signed-off-by: Martin von Zweigbergk <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 811929f commit 38a44bc

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

builtin/log.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1508,10 +1508,6 @@ int cmd_cherry(int argc, const char **argv, const char *prefix)
15081508
}
15091509

15101510
init_revisions(&revs, prefix);
1511-
revs.diff = 1;
1512-
revs.combine_merges = 0;
1513-
revs.ignore_merges = 1;
1514-
DIFF_OPT_SET(&revs.diffopt, RECURSIVE);
15151511

15161512
if (add_pending_commit(head, &revs, 0))
15171513
die(_("Unknown commit %s"), head);

0 commit comments

Comments
 (0)