Skip to content

Commit 3af6792

Browse files
tgcgitster
authored andcommitted
Makefile: handle broken curl version number in version check
curl 7.11.0 through 7.12.2 when built from their official release archives will present a 5 digit version number instead of the documented 6 digits which breaks the version check in the Makefile. Correct these broken version numbers on the fly when extracting them to ensure the comparison works correctly. [jc: shortened the new sed scripts a bit] Signed-off-by: Tom G. Christensen <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 15598cf commit 3af6792

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1035,13 +1035,13 @@ else
10351035
REMOTE_CURL_NAMES = $(REMOTE_CURL_PRIMARY) $(REMOTE_CURL_ALIASES)
10361036
PROGRAM_OBJS += http-fetch.o
10371037
PROGRAMS += $(REMOTE_CURL_NAMES)
1038-
curl_check := $(shell (echo 070908; curl-config --vernum) 2>/dev/null | sort -r | sed -ne 2p)
1038+
curl_check := $(shell (echo 070908; curl-config --vernum | sed -e '/^70[BC]/s/^/0/') 2>/dev/null | sort -r | sed -ne 2p)
10391039
ifeq "$(curl_check)" "070908"
10401040
ifndef NO_EXPAT
10411041
PROGRAM_OBJS += http-push.o
10421042
endif
10431043
endif
1044-
curl_check := $(shell (echo 072200; curl-config --vernum) 2>/dev/null | sort -r | sed -ne 2p)
1044+
curl_check := $(shell (echo 072200; curl-config --vernum | sed -e '/^70[BC]/s/^/0/') 2>/dev/null | sort -r | sed -ne 2p)
10451045
ifeq "$(curl_check)" "072200"
10461046
USE_CURL_FOR_IMAP_SEND = YesPlease
10471047
endif

0 commit comments

Comments
 (0)