upload-pack: fix leaking URI protocols

pks-t · gitster · commit 3b373150c8ea · 2024-11-04T22:37:53.000-08:00
We don't clear `struct upload_pack::uri_protocols`, which causes a
memory leak. Fix this.

Signed-off-by: Patrick Steinhardt &lt;ps@pks.im&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/t5702-protocol-v2.sh b/t/t5702-protocol-v2.sh
@@ -7,6 +7,7 @@ TEST_NO_CREATE_REPO=1
 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 # Test protocol v2 with 'git://' transport
diff --git a/upload-pack.c b/upload-pack.c
@@ -166,6 +166,7 @@ static void upload_pack_data_clear(struct upload_pack_data *data)
 	object_array_clear(&data->extra_edge_obj);
 	list_objects_filter_release(&data->filter_options);
 	string_list_clear(&data->allowed_filters, 0);
+	string_list_clear(&data->uri_protocols, 0);
 
 	free((char *)data->pack_objects_hook);
 }

Original file line number	Diff line number	Diff line change
`@@ -166,6 +166,7 @@ static void upload_pack_data_clear(struct upload_pack_data *data)`
`166`	`166`	`object_array_clear(&data->extra_edge_obj);`
`167`	`167`	`list_objects_filter_release(&data->filter_options);`
`168`	`168`	`string_list_clear(&data->allowed_filters, 0);`
	`169`	`+ string_list_clear(&data->uri_protocols, 0);`
`169`	`170`
`170`	`171`	`free((char *)data->pack_objects_hook);`
`171`	`172`	`}`