Skip to content

Commit 3d6bc9a

Browse files
committed
Revert "merge: pass verbosity flag down to merge-recursive"
This reverts commit 2bf15a3, whose intention was good, but the verbosity levels used in merge-recursive turns out to be rather uneven. For example, a merge of two branches with conflicting submodule updates used to report CONFLICT: output with --quiet but no longer (which *is* desired), while the final "Automatic merge failed; fix conflicts and then commit" message is still shown even with --quiet (which *is* inconsistent). Originally reported by Bryan Turner; it is too early to declare what the concensus is, but it seems that we would need to level the verbosity levels used in merge strategy backends before we can go forward. In the meantime, we'd revert to the old behaviour until that happens. cf. $gmane/267245
1 parent e46fe3d commit 3d6bc9a

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

builtin/merge.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -684,10 +684,6 @@ static int try_merge_strategy(const char *strategy, struct commit_list *common,
684684
o.subtree_shift = "";
685685

686686
o.renormalize = option_renormalize;
687-
if (verbosity < 0)
688-
o.verbosity = verbosity;
689-
else if (verbosity > 0)
690-
o.verbosity += verbosity;
691687
o.show_rename_progress =
692688
show_progress == -1 ? isatty(2) : show_progress;
693689

0 commit comments

Comments
 (0)