Skip to content

Commit 3de4a44

Browse files
MikeRalphsongitster
authored andcommitted
cvsexportcommit: reorder tests to quiet intermittent failure
Reorder tests introduced in fef3a7c and 54d5cc0 so an intermittent but unimportant failure on the CVS side related to the former does not interfere with what is actually being tested. Signed-off-by: Mike Ralphson <[email protected]> Tested-by: Tommy Nordgren <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 58b1ef2 commit 3de4a44

File tree

1 file changed

+22
-19
lines changed

1 file changed

+22
-19
lines changed

t/t9200-git-cvsexportcommit.sh

Lines changed: 22 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -288,14 +288,35 @@ test_expect_success 'check files before directories' '
288288
289289
'
290290

291+
test_expect_success 're-commit a removed filename which remains in CVS attic' '
292+
293+
(cd "$CVSWORK" &&
294+
echo >attic_gremlin &&
295+
cvs -Q add attic_gremlin &&
296+
cvs -Q ci -m "added attic_gremlin" &&
297+
rm attic_gremlin &&
298+
cvs -Q rm attic_gremlin &&
299+
cvs -Q ci -m "removed attic_gremlin") &&
300+
301+
echo > attic_gremlin &&
302+
git add attic_gremlin &&
303+
git commit -m "Added attic_gremlin" &&
304+
git cvsexportcommit -w "$CVSWORK" -c HEAD &&
305+
(cd "$CVSWORK"; cvs -Q update -d) &&
306+
test -f "$CVSWORK/attic_gremlin"
307+
'
308+
309+
# the state of the CVS sandbox may be indeterminate for ' space'
310+
# after this test on some platforms / with some versions of CVS
311+
# consider adding new tests above this point
291312
test_expect_success 'commit a file with leading spaces in the name' '
292313
293314
echo space > " space" &&
294315
git add " space" &&
295316
git commit -m "Add a file with a leading space" &&
296317
id=$(git rev-parse HEAD) &&
297318
git cvsexportcommit -w "$CVSWORK" -c $id &&
298-
check_entries "$CVSWORK" " space/1.1/|DS/1.1/|release-notes/1.2/" &&
319+
check_entries "$CVSWORK" " space/1.1/|DS/1.1/|attic_gremlin/1.3/|release-notes/1.2/" &&
299320
test_cmp "$CVSWORK/ space" " space"
300321
301322
'
@@ -317,22 +338,4 @@ test_expect_success 'use the same checkout for Git and CVS' '
317338
318339
'
319340

320-
test_expect_success 're-commit a removed filename which remains in CVS attic' '
321-
322-
(cd "$CVSWORK" &&
323-
echo >attic_gremlin &&
324-
cvs -Q add attic_gremlin &&
325-
cvs -Q ci -m "added attic_gremlin" &&
326-
rm attic_gremlin &&
327-
cvs -Q rm attic_gremlin &&
328-
cvs -Q ci -m "removed attic_gremlin") &&
329-
330-
echo > attic_gremlin &&
331-
git add attic_gremlin &&
332-
git commit -m "Added attic_gremlin" &&
333-
git cvsexportcommit -w "$CVSWORK" -c HEAD &&
334-
(cd "$CVSWORK"; cvs -Q update -d) &&
335-
test -f "$CVSWORK/attic_gremlin"
336-
'
337-
338341
test_done

0 commit comments

Comments
 (0)