WIP reftable(unit-tests): do make sure to use custom allocators

Just like the preceding commit, this ensures that the tests run with any
custom allocator (such as mimalloc) if Git has been configured to be
built with one.

This addresses the same symptom, this time in the `t/unit-tests/*.exe`
programs: exit code 127 (which really is `STATUS_HEAP_CORRUPTION`
clamped to the maximal 7-bit value).

Signed-off-by: Johannes Schindelin <[email protected]>

Author: dscho

t/unit-tests/lib-reftable.c

@@ -1,11 +1,27 @@
 #define DISABLE_SIGN_COMPARE_WARNINGS
 
+#include "git-compat-util.h"
+
+/*
+ * Save pointers to the custom allocator, if any: `reftable/basics.h` (included
+ * by `lib-reftable.h`) will simply #undef these if they had been defined, and
+ * the information would then be lost.
+ */
+static void *(*git_malloc)(size_t) = malloc;
+static void *(*git_realloc)(void *, size_t) = realloc;
+static void (*git_free)(void *) = free;
+
 #include "lib-reftable.h"
 #include "test-lib.h"
 #include "reftable/constants.h"
 #include "reftable/writer.h"
 #include "strbuf.h"
 
+void t_reftable__initialize(void)
+{
+	reftable_set_alloc(git_malloc, git_realloc, git_free);
+}
+
 void t_reftable_set_hash(uint8_t *p, int i, enum reftable_hash id)
 {
 	memset(p, (uint8_t)i, hash_size(id));

t/unit-tests/lib-reftable.h

@@ -4,6 +4,8 @@
 #include "git-compat-util.h"
 #include "reftable/reftable-writer.h"
 
+void t_reftable__initialize(void);
+
 struct reftable_buf;
 
 void t_reftable_set_hash(uint8_t *p, int i, enum reftable_hash id);

t/unit-tests/t-reftable-basics.c

@@ -7,6 +7,7 @@ license that can be found in the LICENSE file or at
 */
 
 #include "test-lib.h"
+#include "lib-reftable.h"
 #include "reftable/basics.h"
 
 struct integer_needle_lesseq_args {
@@ -27,6 +28,7 @@ static void *realloc_stub(void *p UNUSED, size_t size UNUSED)
 
 int cmd_main(int argc UNUSED, const char *argv[] UNUSED)
 {
+	t_reftable__initialize();
 	if_test ("binary search with binsearch works") {
 		int haystack[] = { 2, 4, 6, 8, 10 };
 		struct {

t/unit-tests/t-reftable-block.c

@@ -7,6 +7,7 @@ license that can be found in the LICENSE file or at
 */
 
 #include "test-lib.h"
+#include "lib-reftable.h"
 #include "reftable/block.h"
 #include "reftable/blocksource.h"
 #include "reftable/constants.h"
@@ -374,6 +375,7 @@ static void t_index_block_read_write(void)
 
 int cmd_main(int argc UNUSED, const char *argv[] UNUSED)
 {
+	t_reftable__initialize();
 	TEST(t_index_block_read_write(), "read-write operations on index blocks work");
 	TEST(t_log_block_read_write(), "read-write operations on log blocks work");
 	TEST(t_obj_block_read_write(), "read-write operations on obj blocks work");

t/unit-tests/t-reftable-merged.c

@@ -535,6 +535,7 @@ static void t_default_write_opts(void)
 
 int cmd_main(int argc UNUSED, const char *argv[] UNUSED)
 {
+	t_reftable__initialize();
 	TEST(t_default_write_opts(), "merged table with default write opts");
 	TEST(t_merged_logs(), "merged table with multiple log updates for same ref");
 	TEST(t_merged_refs(), "merged table with multiple updates to same ref");

t/unit-tests/t-reftable-pq.c

@@ -7,6 +7,7 @@ license that can be found in the LICENSE file or at
 */
 
 #include "test-lib.h"
+#include "lib-reftable.h"
 #include "reftable/constants.h"
 #include "reftable/pq.h"
 #include "strbuf.h"
@@ -153,6 +154,7 @@ static void t_merged_iter_pqueue_top(void)
 
 int cmd_main(int argc UNUSED, const char *argv[] UNUSED)
 {
+	t_reftable__initialize();
 	TEST(t_pq_record(), "pq works with record-based comparison");
 	TEST(t_pq_index(), "pq works with index-based comparison");
 	TEST(t_merged_iter_pqueue_top(), "merged_iter_pqueue_top works");

t/unit-tests/t-reftable-reader.c

@@ -90,6 +90,7 @@ static int t_reader_reseek(void)
 
 int cmd_main(int argc UNUSED, const char *argv[] UNUSED)
 {
+	t_reftable__initialize();
 	TEST(t_reader_seek_once(), "reader can seek once");
 	TEST(t_reader_reseek(), "reader can reseek multiple times");
 	return test_done();

t/unit-tests/t-reftable-readwrite.c

@@ -957,6 +957,7 @@ static void t_corrupt_table(void)
 
 int cmd_main(int argc UNUSED, const char *argv[] UNUSED)
 {
+	t_reftable__initialize();
 	TEST(t_buffer(), "strbuf works as blocksource");
 	TEST(t_corrupt_table(), "read-write on corrupted table");
 	TEST(t_corrupt_table_empty(), "read-write on an empty table");

t/unit-tests/t-reftable-record.c

@@ -7,6 +7,7 @@
 */
 
 #include "test-lib.h"
+#include "lib-reftable.h"
 #include "reftable/basics.h"
 #include "reftable/constants.h"
 #include "reftable/record.h"
@@ -567,6 +568,7 @@ static void t_reftable_index_record_roundtrip(void)
 
 int cmd_main(int argc UNUSED, const char *argv[] UNUSED)
 {
+	t_reftable__initialize();
 	TEST(t_reftable_ref_record_comparison(), "comparison operations work on ref record");
 	TEST(t_reftable_log_record_comparison(), "comparison operations work on log record");
 	TEST(t_reftable_index_record_comparison(), "comparison operations work on index record");

t/unit-tests/t-reftable-stack.c

@@ -1418,6 +1418,7 @@ static void t_reftable_invalid_limit_updates(void)
 
 int cmd_main(int argc UNUSED, const char *argv[] UNUSED)
 {
+	t_reftable__initialize();
 	TEST(t_empty_add(), "empty addition to stack");
 	TEST(t_read_file(), "read_lines works");
 	TEST(t_reflog_expire(), "expire reflog entries");