Merge branch 'rs/archive-plug-leak-refname'

gitster · gitster · commit 3eebb3e04433 · 2020-11-25T15:24:53.000-08:00
Memleak fix.

* rs/archive-plug-leak-refname:
  archive: release refname after use
diff --git a/archive.c b/archive.c
@@ -658,6 +658,7 @@ int write_archive(int argc, const char **argv, const char *prefix,
 	rc = ar->write_archive(ar, &args);
 
 	string_list_clear_func(&args.extra_files, extra_file_info_clear);
+	free(args.refname);
 
 	return rc;
 }
diff --git a/archive.h b/archive.h
@@ -8,7 +8,7 @@ struct repository;
 
 struct archiver_args {
 	struct repository *repo;
-	const char *refname;
+	char *refname;
 	const char *prefix;
 	const char *base;
 	size_t baselen;

Original file line number	Diff line number	Diff line change
`@@ -658,6 +658,7 @@ int write_archive(int argc, const char *argv, const char prefix,`
`658`	`658`	`rc = ar->write_archive(ar, &args);`
`659`	`659`
`660`	`660`	`string_list_clear_func(&args.extra_files, extra_file_info_clear);`
	`661`	`+ free(args.refname);`
`661`	`662`
`662`	`663`	`return rc;`
`663`	`664`	`}`