Skip to content

Commit 3f6ae18

Browse files
gitsterdscho
gitster
authored and
dscho
committed
Merge branch 'js/curl-easy-setopt-typefix'
Adjust to newer version of libcURL. * js/curl-easy-setopt-typefix: curl: pass `long` values where expected
2 parents b65d24b + 1618ae6 commit 3f6ae18

File tree

4 files changed

+37
-37
lines changed

4 files changed

+37
-37
lines changed

‎http-push.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ static char *xml_entities(const char *s)
194194
static void curl_setup_http_get(CURL *curl, const char *url,
195195
const char *custom_req)
196196
{
197-
curl_easy_setopt(curl, CURLOPT_HTTPGET, 1);
197+
curl_easy_setopt(curl, CURLOPT_HTTPGET, 1L);
198198
curl_easy_setopt(curl, CURLOPT_URL, url);
199199
curl_easy_setopt(curl, CURLOPT_CUSTOMREQUEST, custom_req);
200200
curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, fwrite_null);
@@ -204,17 +204,17 @@ static void curl_setup_http(CURL *curl, const char *url,
204204
const char *custom_req, struct buffer *buffer,
205205
curl_write_callback write_fn)
206206
{
207-
curl_easy_setopt(curl, CURLOPT_UPLOAD, 1);
207+
curl_easy_setopt(curl, CURLOPT_UPLOAD, 1L);
208208
curl_easy_setopt(curl, CURLOPT_URL, url);
209209
curl_easy_setopt(curl, CURLOPT_INFILE, buffer);
210210
curl_easy_setopt(curl, CURLOPT_INFILESIZE, buffer->buf.len);
211211
curl_easy_setopt(curl, CURLOPT_READFUNCTION, fread_buffer);
212212
curl_easy_setopt(curl, CURLOPT_SEEKFUNCTION, seek_buffer);
213213
curl_easy_setopt(curl, CURLOPT_SEEKDATA, buffer);
214214
curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, write_fn);
215-
curl_easy_setopt(curl, CURLOPT_NOBODY, 0);
215+
curl_easy_setopt(curl, CURLOPT_NOBODY, 0L);
216216
curl_easy_setopt(curl, CURLOPT_CUSTOMREQUEST, custom_req);
217-
curl_easy_setopt(curl, CURLOPT_UPLOAD, 1);
217+
curl_easy_setopt(curl, CURLOPT_UPLOAD, 1L);
218218
}
219219

220220
static struct curl_slist *get_dav_token_headers(struct remote_lock *lock, enum dav_header_flag options)

‎http.c

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -744,7 +744,7 @@ static int has_proxy_cert_password(void)
744744
#ifdef GITCURL_HAVE_CURLOPT_TCP_KEEPALIVE
745745
static void set_curl_keepalive(CURL *c)
746746
{
747-
curl_easy_setopt(c, CURLOPT_TCP_KEEPALIVE, 1);
747+
curl_easy_setopt(c, CURLOPT_TCP_KEEPALIVE, 1L);
748748
}
749749

750750
#else
@@ -1071,13 +1071,13 @@ static CURL *get_curl_handle(void)
10711071
die("curl_easy_init failed");
10721072

10731073
if (!curl_ssl_verify) {
1074-
curl_easy_setopt(result, CURLOPT_SSL_VERIFYPEER, 0);
1075-
curl_easy_setopt(result, CURLOPT_SSL_VERIFYHOST, 0);
1074+
curl_easy_setopt(result, CURLOPT_SSL_VERIFYPEER, 0L);
1075+
curl_easy_setopt(result, CURLOPT_SSL_VERIFYHOST, 0L);
10761076
} else {
10771077
/* Verify authenticity of the peer's certificate */
1078-
curl_easy_setopt(result, CURLOPT_SSL_VERIFYPEER, 1);
1078+
curl_easy_setopt(result, CURLOPT_SSL_VERIFYPEER, 1L);
10791079
/* The name in the cert must match whom we tried to connect */
1080-
curl_easy_setopt(result, CURLOPT_SSL_VERIFYHOST, 2);
1080+
curl_easy_setopt(result, CURLOPT_SSL_VERIFYHOST, 2L);
10811081
}
10821082

10831083
#ifdef GIT_CURL_HAVE_CURL_HTTP_VERSION_2
@@ -1192,8 +1192,8 @@ static CURL *get_curl_handle(void)
11921192
curl_low_speed_time);
11931193
}
11941194

1195-
curl_easy_setopt(result, CURLOPT_MAXREDIRS, 20);
1196-
curl_easy_setopt(result, CURLOPT_POSTREDIR, CURL_REDIR_POST_ALL);
1195+
curl_easy_setopt(result, CURLOPT_MAXREDIRS, 20L);
1196+
curl_easy_setopt(result, CURLOPT_POSTREDIR, (long)CURL_REDIR_POST_ALL);
11971197

11981198
#ifdef GIT_CURL_HAVE_CURLOPT_PROTOCOLS_STR
11991199
{
@@ -1226,7 +1226,7 @@ static CURL *get_curl_handle(void)
12261226
user_agent ? user_agent : git_user_agent());
12271227

12281228
if (curl_ftp_no_epsv)
1229-
curl_easy_setopt(result, CURLOPT_FTP_USE_EPSV, 0);
1229+
curl_easy_setopt(result, CURLOPT_FTP_USE_EPSV, 0L);
12301230

12311231
if (curl_ssl_try)
12321232
curl_easy_setopt(result, CURLOPT_USE_SSL, CURLUSESSL_TRY);
@@ -1268,19 +1268,19 @@ static CURL *get_curl_handle(void)
12681268

12691269
if (starts_with(curl_http_proxy, "socks5h"))
12701270
curl_easy_setopt(result,
1271-
CURLOPT_PROXYTYPE, CURLPROXY_SOCKS5_HOSTNAME);
1271+
CURLOPT_PROXYTYPE, (long)CURLPROXY_SOCKS5_HOSTNAME);
12721272
else if (starts_with(curl_http_proxy, "socks5"))
12731273
curl_easy_setopt(result,
1274-
CURLOPT_PROXYTYPE, CURLPROXY_SOCKS5);
1274+
CURLOPT_PROXYTYPE, (long)CURLPROXY_SOCKS5);
12751275
else if (starts_with(curl_http_proxy, "socks4a"))
12761276
curl_easy_setopt(result,
1277-
CURLOPT_PROXYTYPE, CURLPROXY_SOCKS4A);
1277+
CURLOPT_PROXYTYPE, (long)CURLPROXY_SOCKS4A);
12781278
else if (starts_with(curl_http_proxy, "socks"))
12791279
curl_easy_setopt(result,
1280-
CURLOPT_PROXYTYPE, CURLPROXY_SOCKS4);
1280+
CURLOPT_PROXYTYPE, (long)CURLPROXY_SOCKS4);
12811281
#ifdef GIT_CURL_HAVE_CURLOPT_PROXY_KEYPASSWD
12821282
else if (starts_with(curl_http_proxy, "https")) {
1283-
curl_easy_setopt(result, CURLOPT_PROXYTYPE, CURLPROXY_HTTPS);
1283+
curl_easy_setopt(result, CURLOPT_PROXYTYPE, (long)CURLPROXY_HTTPS);
12841284

12851285
if (http_proxy_ssl_cert)
12861286
curl_easy_setopt(result, CURLOPT_PROXY_SSLCERT, http_proxy_ssl_cert);
@@ -1588,9 +1588,9 @@ struct active_request_slot *get_active_slot(void)
15881588
curl_easy_setopt(slot->curl, CURLOPT_WRITEFUNCTION, NULL);
15891589
curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDS, NULL);
15901590
curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDSIZE, -1L);
1591-
curl_easy_setopt(slot->curl, CURLOPT_UPLOAD, 0);
1592-
curl_easy_setopt(slot->curl, CURLOPT_HTTPGET, 1);
1593-
curl_easy_setopt(slot->curl, CURLOPT_FAILONERROR, 1);
1591+
curl_easy_setopt(slot->curl, CURLOPT_UPLOAD, 0L);
1592+
curl_easy_setopt(slot->curl, CURLOPT_HTTPGET, 1L);
1593+
curl_easy_setopt(slot->curl, CURLOPT_FAILONERROR, 1L);
15941594
curl_easy_setopt(slot->curl, CURLOPT_RANGE, NULL);
15951595

15961596
/*
@@ -1599,9 +1599,9 @@ struct active_request_slot *get_active_slot(void)
15991599
* HTTP_FOLLOW_* cases themselves.
16001600
*/
16011601
if (http_follow_config == HTTP_FOLLOW_ALWAYS)
1602-
curl_easy_setopt(slot->curl, CURLOPT_FOLLOWLOCATION, 1);
1602+
curl_easy_setopt(slot->curl, CURLOPT_FOLLOWLOCATION, 1L);
16031603
else
1604-
curl_easy_setopt(slot->curl, CURLOPT_FOLLOWLOCATION, 0);
1604+
curl_easy_setopt(slot->curl, CURLOPT_FOLLOWLOCATION, 0L);
16051605

16061606
curl_easy_setopt(slot->curl, CURLOPT_IPRESOLVE, git_curl_ipresolve);
16071607
curl_easy_setopt(slot->curl, CURLOPT_HTTPAUTH, http_auth_methods);
@@ -2170,12 +2170,12 @@ static int http_request(const char *url,
21702170
int ret;
21712171

21722172
slot = get_active_slot();
2173-
curl_easy_setopt(slot->curl, CURLOPT_HTTPGET, 1);
2173+
curl_easy_setopt(slot->curl, CURLOPT_HTTPGET, 1L);
21742174

21752175
if (!result) {
2176-
curl_easy_setopt(slot->curl, CURLOPT_NOBODY, 1);
2176+
curl_easy_setopt(slot->curl, CURLOPT_NOBODY, 1L);
21772177
} else {
2178-
curl_easy_setopt(slot->curl, CURLOPT_NOBODY, 0);
2178+
curl_easy_setopt(slot->curl, CURLOPT_NOBODY, 0L);
21792179
curl_easy_setopt(slot->curl, CURLOPT_WRITEDATA, result);
21802180

21812181
if (target == HTTP_REQUEST_FILE) {
@@ -2201,7 +2201,7 @@ static int http_request(const char *url,
22012201
strbuf_addstr(&buf, " no-cache");
22022202
if (options && options->initial_request &&
22032203
http_follow_config == HTTP_FOLLOW_INITIAL)
2204-
curl_easy_setopt(slot->curl, CURLOPT_FOLLOWLOCATION, 1);
2204+
curl_easy_setopt(slot->curl, CURLOPT_FOLLOWLOCATION, 1L);
22052205

22062206
headers = curl_slist_append(headers, buf.buf);
22072207

@@ -2220,7 +2220,7 @@ static int http_request(const char *url,
22202220
curl_easy_setopt(slot->curl, CURLOPT_URL, url);
22212221
curl_easy_setopt(slot->curl, CURLOPT_HTTPHEADER, headers);
22222222
curl_easy_setopt(slot->curl, CURLOPT_ENCODING, "");
2223-
curl_easy_setopt(slot->curl, CURLOPT_FAILONERROR, 0);
2223+
curl_easy_setopt(slot->curl, CURLOPT_FAILONERROR, 0L);
22242224

22252225
ret = run_one_slot(slot, &results);
22262226

@@ -2782,7 +2782,7 @@ struct http_object_request *new_http_object_request(const char *base_url,
27822782
freq->headers = object_request_headers();
27832783

27842784
curl_easy_setopt(freq->slot->curl, CURLOPT_WRITEDATA, freq);
2785-
curl_easy_setopt(freq->slot->curl, CURLOPT_FAILONERROR, 0);
2785+
curl_easy_setopt(freq->slot->curl, CURLOPT_FAILONERROR, 0L);
27862786
curl_easy_setopt(freq->slot->curl, CURLOPT_WRITEFUNCTION, fwrite_sha1_file);
27872787
curl_easy_setopt(freq->slot->curl, CURLOPT_ERRORBUFFER, freq->errorstr);
27882788
curl_easy_setopt(freq->slot->curl, CURLOPT_URL, freq->url);

‎imap-send.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1414,7 +1414,7 @@ static CURL *setup_curl(struct imap_server_conf *srvc, struct credential *cred)
14141414

14151415
curl_easy_setopt(curl, CURLOPT_URL, path.buf);
14161416
strbuf_release(&path);
1417-
curl_easy_setopt(curl, CURLOPT_PORT, srvc->port);
1417+
curl_easy_setopt(curl, CURLOPT_PORT, (long)srvc->port);
14181418

14191419
if (srvc->auth_method) {
14201420
#ifndef GIT_CURL_HAVE_CURLOPT_LOGIN_OPTIONS
@@ -1431,8 +1431,8 @@ static CURL *setup_curl(struct imap_server_conf *srvc, struct credential *cred)
14311431
if (!srvc->use_ssl)
14321432
curl_easy_setopt(curl, CURLOPT_USE_SSL, (long)CURLUSESSL_TRY);
14331433

1434-
curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, srvc->ssl_verify);
1435-
curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, srvc->ssl_verify);
1434+
curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, (long)srvc->ssl_verify);
1435+
curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, (long)srvc->ssl_verify);
14361436

14371437
curl_easy_setopt(curl, CURLOPT_READFUNCTION, fread_buffer);
14381438

‎remote-curl.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -876,12 +876,12 @@ static int probe_rpc(struct rpc_state *rpc, struct slot_results *results)
876876
headers = curl_slist_append(headers, rpc->hdr_content_type);
877877
headers = curl_slist_append(headers, rpc->hdr_accept);
878878

879-
curl_easy_setopt(slot->curl, CURLOPT_NOBODY, 0);
880-
curl_easy_setopt(slot->curl, CURLOPT_POST, 1);
879+
curl_easy_setopt(slot->curl, CURLOPT_NOBODY, 0L);
880+
curl_easy_setopt(slot->curl, CURLOPT_POST, 1L);
881881
curl_easy_setopt(slot->curl, CURLOPT_URL, rpc->service_url);
882882
curl_easy_setopt(slot->curl, CURLOPT_ENCODING, NULL);
883883
curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDS, "0000");
884-
curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDSIZE, 4);
884+
curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDSIZE, 4L);
885885
curl_easy_setopt(slot->curl, CURLOPT_HTTPHEADER, headers);
886886
curl_easy_setopt(slot->curl, CURLOPT_WRITEFUNCTION, fwrite_buffer);
887887
curl_easy_setopt(slot->curl, CURLOPT_WRITEDATA, &buf);
@@ -969,8 +969,8 @@ static int post_rpc(struct rpc_state *rpc, int stateless_connect, int flush_rece
969969

970970
slot = get_active_slot();
971971

972-
curl_easy_setopt(slot->curl, CURLOPT_NOBODY, 0);
973-
curl_easy_setopt(slot->curl, CURLOPT_POST, 1);
972+
curl_easy_setopt(slot->curl, CURLOPT_NOBODY, 0L);
973+
curl_easy_setopt(slot->curl, CURLOPT_POST, 1L);
974974
curl_easy_setopt(slot->curl, CURLOPT_URL, rpc->service_url);
975975
curl_easy_setopt(slot->curl, CURLOPT_ENCODING, "");
976976

@@ -1057,7 +1057,7 @@ static int post_rpc(struct rpc_state *rpc, int stateless_connect, int flush_rece
10571057
rpc_in_data.check_pktline = stateless_connect;
10581058
memset(&rpc_in_data.pktline_state, 0, sizeof(rpc_in_data.pktline_state));
10591059
curl_easy_setopt(slot->curl, CURLOPT_WRITEDATA, &rpc_in_data);
1060-
curl_easy_setopt(slot->curl, CURLOPT_FAILONERROR, 0);
1060+
curl_easy_setopt(slot->curl, CURLOPT_FAILONERROR, 0L);
10611061

10621062

10631063
rpc->any_written = 0;

0 commit comments

Comments
 (0)