Skip to content

Commit 3f784a4

Browse files
sschuberthgitster
authored andcommitted
git.c: consistently use the term "builtin" instead of "internal command"
Signed-off-by: Sebastian Schuberth <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 4448466 commit 3f784a4

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

Documentation/technical/api-builtin.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Git:
1414

1515
. Add the external declaration for the function to `builtin.h`.
1616

17-
. Add the command to `commands[]` table in `handle_internal_command()`,
17+
. Add the command to `commands[]` table in `handle_builtin()`,
1818
defined in `git.c`. The entry should look like:
1919

2020
{ "foo", cmd_foo, <options> },

git.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv)
332332
return 0;
333333
}
334334

335-
static void handle_internal_command(int argc, const char **argv)
335+
static void handle_builtin(int argc, const char **argv)
336336
{
337337
const char *cmd = argv[0];
338338
static struct cmd_struct commands[] = {
@@ -517,8 +517,8 @@ static int run_argv(int *argcp, const char ***argv)
517517
int done_alias = 0;
518518

519519
while (1) {
520-
/* See if it's an internal command */
521-
handle_internal_command(*argcp, *argv);
520+
/* See if it's a builtin */
521+
handle_builtin(*argcp, *argv);
522522

523523
/* .. then try the external ones */
524524
execv_dashed_external(*argv);
@@ -563,14 +563,14 @@ int main(int argc, char **av)
563563
* - cannot execute it externally (since it would just do
564564
* the same thing over again)
565565
*
566-
* So we just directly call the internal command handler, and
567-
* die if that one cannot handle it.
566+
* So we just directly call the builtin handler, and die if
567+
* that one cannot handle it.
568568
*/
569569
if (starts_with(cmd, "git-")) {
570570
cmd += 4;
571571
argv[0] = cmd;
572-
handle_internal_command(argc, argv);
573-
die("cannot handle %s internally", cmd);
572+
handle_builtin(argc, argv);
573+
die("cannot handle %s as a builtin", cmd);
574574
}
575575

576576
/* Look for flags.. */

0 commit comments

Comments
 (0)