Skip to content

Commit 402596a

Browse files
felipecgitster
authored andcommitted
send-email: make annotate configurable
Some people always do --annotate, lets not force them to always type that. Signed-off-by: Felipe Contreras <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 21ccebe commit 402596a

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

Documentation/config.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1998,6 +1998,7 @@ sendemail.<identity>.*::
19981998

19991999
sendemail.aliasesfile::
20002000
sendemail.aliasfiletype::
2001+
sendemail.annotate::
20012002
sendemail.bcc::
20022003
sendemail.cc::
20032004
sendemail.cccmd::

Documentation/git-send-email.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,9 @@ Composing
4545
~~~~~~~~~
4646

4747
--annotate::
48-
Review and edit each patch you're about to send. See the
49-
CONFIGURATION section for 'sendemail.multiedit'.
48+
Review and edit each patch you're about to send. Default is the value
49+
of 'sendemail.annotate'. See the CONFIGURATION section for
50+
'sendemail.multiedit'.
5051

5152
--bcc=<address>::
5253
Specify a "Bcc:" value for each email. Default is the value of

git-send-email.perl

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ sub usage {
5454
--[no-]bcc <str> * Email Bcc:
5555
--subject <str> * Email "Subject:"
5656
--in-reply-to <str> * Email "In-Reply-To:"
57-
--annotate * Review each patch that will be sent in an editor.
57+
--[no-]annotate * Review each patch that will be sent in an editor.
5858
--compose * Open an editor for introduction.
5959
--compose-encoding <str> * Encoding to assume for introduction.
6060
--8bit-encoding <str> * Encoding to assume 8bit mails if undeclared
@@ -212,7 +212,8 @@ sub do_edit {
212212
"signedoffbycc" => [\$signed_off_by_cc, undef],
213213
"signedoffcc" => [\$signed_off_by_cc, undef], # Deprecated
214214
"validate" => [\$validate, 1],
215-
"multiedit" => [\$multiedit, undef]
215+
"multiedit" => [\$multiedit, undef],
216+
"annotate" => [\$annotate, undef]
216217
);
217218

218219
my %config_settings = (
@@ -304,7 +305,7 @@ sub signal_handler {
304305
"smtp-debug:i" => \$debug_net_smtp,
305306
"smtp-domain:s" => \$smtp_domain,
306307
"identity=s" => \$identity,
307-
"annotate" => \$annotate,
308+
"annotate!" => \$annotate,
308309
"compose" => \$compose,
309310
"quiet" => \$quiet,
310311
"cc-cmd=s" => \$cc_cmd,

0 commit comments

Comments
 (0)