Skip to content

Commit 40a9c3c

Browse files
committed
Merge branch 'jn/gitweb-install-doc' into maint
* jn/gitweb-install-doc: gitweb/INSTALL: GITWEB_CONFIG_SYSTEM is for backward compatibility gitweb/INSTALL: Simplify description of GITWEB_CONFIG_SYSTEM
2 parents 1a475c4 + 1a39b72 commit 40a9c3c

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

Documentation/gitweb.conf.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -857,6 +857,13 @@ adding the following lines to your gitweb configuration file:
857857
$known_snapshot_formats{'zip'}{'disabled'} = 1;
858858
$known_snapshot_formats{'tgz'}{'compressor'} = ['gzip','-6'];
859859

860+
BUGS
861+
----
862+
Debugging would be easier if the fallback configuration file
863+
(`/etc/gitweb.conf`) and environment variable to override its location
864+
('GITWEB_CONFIG_SYSTEM') had names reflecting their "fallback" role.
865+
The current names are kept to avoid breaking working setups.
866+
860867
ENVIRONMENT
861868
-----------
862869
The location of per-instance and system-wide configuration files can be

gitweb/INSTALL

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -243,14 +243,11 @@ for gitweb (in gitweb/README), and gitweb.conf(5) manpage.
243243
GITWEB_CONFIG_SYSTEM build configuration variable, and override it
244244
through the GITWEB_CONFIG_SYSTEM environment variable.
245245

246-
Note that if per-instance configuration file exists, then system-wide
247-
configuration is _not used at all_. This is quite untypical and surprising
248-
behavior. On the other hand changing current behavior would break backwards
249-
compatibility and can lead to unexpected changes in gitweb behavior.
250-
Therefore gitweb also looks for common system-wide configuration file,
251-
normally /etc/gitweb-common.conf (set during build time using build time
252-
configuration variable GITWEB_CONFIG_COMMON, set it at runtime using
253-
environment variable with the same name). Settings from per-instance or
246+
Note that the GITWEB_CONFIG_SYSTEM system-wide configuration file is
247+
only used for instances that lack per-instance configuration file.
248+
You can use GITWEB_CONFIG_COMMON common system-wide configuration
249+
file (normally /etc/gitweb-common.conf) to keep common default
250+
settings that apply to all instances. Settings from per-instance or
254251
system-wide configuration file override those from common system-wide
255252
configuration file.
256253

0 commit comments

Comments
 (0)