You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
i5500-git-daemon.sh: use compile-able version of Git without OpenSSL
For the interop tests exercising basic 'git daemon' functionality, we
use version v1.0.0 as the old version of Git (which in this test we
happen to designate with using VERSION_B).
But that version does not compile with modern versions of OpenSSL,
complaining with error messages like:
epoch.c:21:16: error: field ‘numerator’ has incomplete type
21 | BIGNUM numerator;
| ^~~~~~~~~
epoch.c:22:16: error: field ‘denominator’ has incomplete type
22 | BIGNUM denominator;
| ^~~~~~~~~~~
epoch.c: In function ‘new_zero’:
Of course, compiling with `NO_OPENSSL=1`, which we have had since
dd53c7a ([PATCH] Support for NO_OPENSSL, 2005-07-29) allows us to
compile cleanly.
This hasn't been such a problem in practice because most builds can use
NO_OPENSSL when compiling the older versions of Git used by the interop
tests, because often even the current version of Git does not use
OpenSSL (e.g., because we use the collision detecting implementation of
SHA-1).
But subsequent changes will make a build configuration that does use
OpenSSL's SHA-1 implementation (at least for non-cryptographic uses)
more common, thus breaking this interop build (since only one side will
compile with NO_OPENSSL).
Let's work around the issue by using a slightly more modern, but still
quite old v1.6.6.3, which is used by the i0000-basic.sh test script as
well.
Signed-off-by: Taylor Blau <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
0 commit comments