Skip to content

Commit 41feac6

Browse files
Denton-Lgitster
authored andcommitted
t9400: don't use test_must_fail with cvs
We are using `test_must_fail cvs` to test that the cvs command fails as expected. However, test_must_fail() is used to ensure that commands fail in an expected way, not due to something like a segv. Since we are not in the business of verifying the sanity of the external world, replace `test_must_fail cvs` with `! cvs` and assume that the cvs command does not die unexpectedly. Signed-off-by: Denton Liu <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 6e7b0ea commit 41feac6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/t9400-git-cvsserver-server.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -603,7 +603,7 @@ test_expect_success 'cvs server does not run with vanilla git-shell' '
603603
cd cvswork &&
604604
CVS_SERVER=$WORKDIR/remote-cvs &&
605605
export CVS_SERVER &&
606-
test_must_fail cvs log merge
606+
! cvs log merge
607607
)
608608
'
609609

0 commit comments

Comments
 (0)