Skip to content

Commit 43a2220

Browse files
peffgitster
authored andcommitted
t7415: rename to expand scope
This script has already expanded beyond its original intent of ".. in submodule names" to include other malicious submodule bits. Let's update the name and description to reflect that, as well as the fact that we'll soon be adding similar tests for other dotfiles (.gitattributes, etc). We'll also renumber it to move it out of the group of submodule-specific tests. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 0282f67 commit 43a2220

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

t/t7415-submodule-names.sh renamed to t/t7450-bad-git-dotfiles.sh

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,16 @@
11
#!/bin/sh
22

3-
test_description='check handling of .. in submodule names
3+
test_description='check broken or malicious patterns in .git* files
44
5-
Exercise the name-checking function on a variety of names, and then give a
6-
real-world setup that confirms we catch this in practice.
5+
Such as:
6+
7+
- presence of .. in submodule names;
8+
Exercise the name-checking function on a variety of names, and then give a
9+
real-world setup that confirms we catch this in practice.
10+
11+
- nested submodule names
12+
13+
- symlinked .gitmodules, etc
714
'
815
. ./test-lib.sh
916
. "$TEST_DIRECTORY"/lib-pack.sh

0 commit comments

Comments
 (0)