Skip to content

Commit 4481ff0

Browse files
davvidgitster
authored andcommitted
mergetool--lib: specialize diff options for emerge and ecmerge
The ecmerge documentation mentions the following form: ecmerge --mode=diff2 $1 $2 Since git-difftool is about diffing, we should use that instead of --mode=merge2. Likewise, this drops the $MERGED argument to emerge, as discussed on the git list ($gmane/117930). Signed-off-by: David Aguilar <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent f01f109 commit 4481ff0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

git-mergetool--lib.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -228,8 +228,8 @@ run_merge_tool () {
228228
fi
229229
check_unchanged
230230
else
231-
"$merge_tool_path" "$LOCAL" "$REMOTE" \
232-
--default --mode=merge2 --to="$MERGED"
231+
"$merge_tool_path" --default --mode=diff2 \
232+
"$LOCAL" "$REMOTE"
233233
fi
234234
;;
235235
emerge)
@@ -248,7 +248,7 @@ run_merge_tool () {
248248
status=$?
249249
else
250250
"$merge_tool_path" -f emerge-files-command \
251-
"$LOCAL" "$REMOTE" "$(basename "$MERGED")"
251+
"$LOCAL" "$REMOTE"
252252
fi
253253
;;
254254
tortoisemerge)

0 commit comments

Comments
 (0)