Skip to content

Commit 44a9ced

Browse files
committed
Merge branch 'svn-fe' of git://repo.or.cz/git/jrn
* 'svn-fe' of git://repo.or.cz/git/jrn: tests: kill backgrounded processes more robustly vcs-svn: a void function shouldn't try to return something tests: make sure input to sed is newline terminated vcs-svn: add missing cast to printf argument
2 parents 537d990 + a892a2d commit 44a9ced

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

t/t0081-line-buffer.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ long_read_test () {
4747
rm -f input &&
4848
mkfifo input &&
4949
{
50-
{
50+
(
5151
generate_tens_of_lines $tens_of_lines "$line" &&
52-
sleep 100
53-
} >input &
52+
exec sleep 100
53+
) >input &
5454
} &&
5555
test-line-buffer input <<-EOF >output &&
5656
binary $readsize
@@ -109,11 +109,11 @@ test_expect_success PIPE '1-byte read, no input available' '
109109
rm -f input &&
110110
mkfifo input &&
111111
{
112-
{
112+
(
113113
printf "%s" a &&
114114
printf "%s" b &&
115-
sleep 100
116-
} >input &
115+
exec sleep 100
116+
) >input &
117117
} &&
118118
test-line-buffer input <<-\EOF >actual &&
119119
binary 1

t/t9010-svn-fe.sh

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ test_expect_success 'NUL in log message, file content, and property name' '
407407
OBJID
408408
:000000 100644 OBJID OBJID A greeting
409409
EOF
410-
printf "\n%s" "something with an ASCII NUL (Q)" >expect.message &&
410+
printf "\n%s\n" "something with an ASCII NUL (Q)" >expect.message &&
411411
printf "%s\n" "helQo" >expect.hello1 &&
412412
printf "%s\n" "link hello" >expect.hello2 &&
413413
{
@@ -465,7 +465,11 @@ test_expect_success 'NUL in log message, file content, and property name' '
465465
git diff-tree --root --stdin |
466466
sed "s/$_x40/OBJID/g"
467467
} >actual &&
468-
git cat-file commit HEAD | nul_to_q | sed -ne "/^\$/,\$ p" >actual.message &&
468+
{
469+
git cat-file commit HEAD | nul_to_q &&
470+
echo
471+
} |
472+
sed -ne "/^\$/,\$ p" >actual.message &&
469473
git cat-file blob HEAD^:greeting | nul_to_q >actual.hello1 &&
470474
git cat-file blob HEAD:greeting | nul_to_q >actual.hello2 &&
471475
test_cmp expect actual &&

vcs-svn/svndump.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,8 @@ static void handle_node(void)
214214
if (have_text || have_props || node_ctx.srcRev)
215215
die("invalid dump: deletion node has "
216216
"copyfrom info, text, or properties");
217-
return repo_delete(node_ctx.dst);
217+
repo_delete(node_ctx.dst);
218+
return;
218219
}
219220
if (node_ctx.action == NODEACT_REPLACE) {
220221
repo_delete(node_ctx.dst);

0 commit comments

Comments
 (0)