Skip to content

Commit 44cecbf

Browse files
pcloudsgitster
authored andcommitted
show-branch: note about its object flags usage
This is another candidate for commit-slab. Keep Junio's observation in code so we can search it later on when somebody wants to improve the code. Signed-off-by: Junio C Hamano <[email protected]>
1 parent 60855a5 commit 44cecbf

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

builtin/show-branch.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,11 @@ static int showbranch_use_color = -1;
2222

2323
static struct argv_array default_args = ARGV_ARRAY_INIT;
2424

25+
/*
26+
* TODO: convert this use of commit->object.flags to commit-slab
27+
* instead to store a pointer to ref name directly. Then use the same
28+
* UNINTERESTING definition from revision.h here.
29+
*/
2530
#define UNINTERESTING 01
2631

2732
#define REV_SHIFT 2

object.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ struct object_array {
4343
* builtin/index-pack.c: 2021
4444
* builtin/pack-objects.c: 20
4545
* builtin/reflog.c: 10--12
46+
* builtin/show-branch.c: 0-------------------------------------------26
4647
* builtin/unpack-objects.c: 2021
4748
*/
4849
#define FLAG_BITS 27

0 commit comments

Comments
 (0)