Skip to content

Commit 44db6f7

Browse files
committed
CodingGuidelines: spaces around C operators
As we have operated with "write like how your surrounding code is written" for too long, after a huge code drop from another project, we'll end up being inconsistent before such an imported code is cleaned up. We have many uses of cast operator with a space before its operand, mostly in the reftable code. Spell the convention out before it spreads to other places. Signed-off-by: Junio C Hamano <[email protected]>
1 parent fa3b914 commit 44db6f7

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

Documentation/CodingGuidelines

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,9 @@ For C programs:
293293
v12.01, 2022-03-28).
294294

295295
- Variables have to be declared at the beginning of the block, before
296-
the first statement (i.e. -Wdeclaration-after-statement).
296+
the first statement (i.e. -Wdeclaration-after-statement). It is
297+
encouraged to have a blank line between the end of the declarations
298+
and the first statement in the block.
297299

298300
- NULL pointers shall be written as NULL, not as 0.
299301

@@ -313,6 +315,13 @@ For C programs:
313315
while( condition )
314316
func (bar+1);
315317

318+
- A binary operator (other than ",") and ternary conditional "?:"
319+
have a space on each side of the operator to separate it from its
320+
operands. E.g. "A + 1", not "A+1".
321+
322+
- A unary operator (other than "." and "->") have no space between it
323+
and its operand. E.g. "(char *)ptr", not "(char *) ptr".
324+
316325
- Do not explicitly compare an integral value with constant 0 or '\0',
317326
or a pointer value with constant NULL. For instance, to validate that
318327
counted array <ptr, cnt> is initialized but has no elements, write:

0 commit comments

Comments
 (0)