Skip to content

Commit 4612edc

Browse files
avargitster
authored andcommitted
tag: remove a TODO item from the test suite
Change the test for "git tag -l" to not have an associated TODO comment saying that it should return non-zero if there's no tags. This was added in commit ef5a6fb ("Add test-script for git-tag", 2007-06-28) when the tests for "tag" were initially added, but at this point changing this would be inconsistent with how "git tag" is a synonym for "git tag -l", and would needlessly break external code that relies on this porcelain command. Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent b643827 commit 4612edc

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

t/t7004-tag.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ tag_exists () {
1616
git show-ref --quiet --verify refs/tags/"$1"
1717
}
1818

19-
# todo: git tag -l now returns always zero, when fixed, change this test
2019
test_expect_success 'listing all tags in an empty tree should succeed' '
2120
git tag -l &&
2221
git tag
@@ -136,7 +135,6 @@ test_expect_success \
136135
'listing a tag using a matching pattern should output that tag' \
137136
'test $(git tag -l mytag) = mytag'
138137

139-
# todo: git tag -l now returns always zero, when fixed, change this test
140138
test_expect_success \
141139
'listing tags using a non-matching pattern should suceed' \
142140
'git tag -l xxx'

0 commit comments

Comments
 (0)