Skip to content

Commit 473f4c9

Browse files
avargitster
authored andcommitted
apply: get rid of useless x < 0 comparison on a size_t type
According to the C standard size_t is always unsigned, therefore the comparison "n1 < 0 || n2 < 0" when n1 and n2 are size_t will always be false. This was raised by clang 2.9 which throws this warning when compiling apply.c: builtin/apply.c:253:9: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] if (n1 < 0 || n2 < 0) ~~ ^ ~ builtin/apply.c:253:19: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] if (n1 < 0 || n2 < 0) ~~ ^ ~ This check was originally added in v1.6.5-rc0~53^2 by Giuseppe Bilotta while adding an option to git-apply to ignore whitespace differences. Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 703f05a commit 473f4c9

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

builtin/apply.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -250,9 +250,6 @@ static int fuzzy_matchlines(const char *s1, size_t n1,
250250
const char *last2 = s2 + n2 - 1;
251251
int result = 0;
252252

253-
if (n1 < 0 || n2 < 0)
254-
return 0;
255-
256253
/* ignore line endings */
257254
while ((*last1 == '\r') || (*last1 == '\n'))
258255
last1--;

0 commit comments

Comments
 (0)