Skip to content

Commit 478afad

Browse files
patthoytspaulusmack
authored andcommitted
gitk: Avoid crash if closed while reading references
As recorded in msysGit issue 125, if the user closes gitk while it reports itself as still reading references then Tk will crash in the geometry management code. This has been fixed for Tk 8.5.7 and above. This patch avoids the problem by flushing outstanding geometry events before calling the readrefs procedure. See also http://code.google.com/p/msysgit/issues/detail?id=125 Signed-off-by: Pat Thoyts <[email protected]> Signed-off-by: Paul Mackerras <[email protected]>
1 parent b575b2f commit 478afad

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

gitk

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11128,6 +11128,7 @@ catch {
1112811128
# wait for the window to become visible
1112911129
tkwait visibility .
1113011130
wm title . "[file tail $argv0]: [file tail [pwd]]"
11131+
update
1113111132
readrefs
1113211133

1113311134
if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd ne {}} {

0 commit comments

Comments
 (0)