Skip to content

Commit 47f16e8

Browse files
committed
Merge branch 'cb/maint-orphan-merge-noclobber' into maint
* cb/maint-orphan-merge-noclobber: do not overwrite untracked during merge from unborn branch
2 parents 54d04f2 + 172b642 commit 47f16e8

File tree

2 files changed

+35
-1
lines changed

2 files changed

+35
-1
lines changed

builtin/merge.c

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,24 @@ static void save_state(void)
233233
die("not a valid object: %s", buffer.buf);
234234
}
235235

236+
static void read_empty(unsigned const char *sha1, int verbose)
237+
{
238+
int i = 0;
239+
const char *args[7];
240+
241+
args[i++] = "read-tree";
242+
if (verbose)
243+
args[i++] = "-v";
244+
args[i++] = "-m";
245+
args[i++] = "-u";
246+
args[i++] = EMPTY_TREE_SHA1_HEX;
247+
args[i++] = sha1_to_hex(sha1);
248+
args[i] = NULL;
249+
250+
if (run_command_v_opt(args, RUN_GIT_CMD))
251+
die("read-tree failed");
252+
}
253+
236254
static void reset_hard(unsigned const char *sha1, int verbose)
237255
{
238256
int i = 0;
@@ -993,7 +1011,7 @@ int cmd_merge(int argc, const char **argv, const char *prefix)
9931011
die("%s - not something we can merge", argv[0]);
9941012
update_ref("initial pull", "HEAD", remote_head->sha1, NULL, 0,
9951013
DIE_ON_ERR);
996-
reset_hard(remote_head->sha1, 0);
1014+
read_empty(remote_head->sha1, 0);
9971015
return 0;
9981016
} else {
9991017
struct strbuf merge_names = STRBUF_INIT;

t/t7607-merge-overwrite.sh

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,4 +84,20 @@ test_expect_success 'will not overwrite removed file with staged changes' '
8484
test_cmp important c1.c
8585
'
8686

87+
cat >expect <<\EOF
88+
error: Untracked working tree file 'c0.c' would be overwritten by merge.
89+
fatal: read-tree failed
90+
EOF
91+
92+
test_expect_success 'will not overwrite untracked file on unborn branch' '
93+
git reset --hard c0 &&
94+
git rm -fr . &&
95+
git checkout --orphan new &&
96+
cp important c0.c &&
97+
test_must_fail git merge c0 2>out &&
98+
test_cmp out expect &&
99+
test_path_is_missing .git/MERGE_HEAD &&
100+
test_cmp important c0.c
101+
'
102+
87103
test_done

0 commit comments

Comments
 (0)