Skip to content

Commit 489c85f

Browse files
newrengitster
authored andcommitted
t6416: correct expectation for rename/rename(1to2) + directory/file
When files are renamed and modified, we need to do three-way content merges to get the appropriate content in the right location. When we have a rename/rename(1to2) conflict (both sides rename the same file, but differently), that merged content should be placed in each of the two resulting files. merge-recursive handled that fine when that was all that was involved, but when one or more of the two resulting files were ALSO involved in a directory/file conflict, it failed to propagate the merged content to that file. Unfortunately, the one test in t6416 that touched on this combination of cases had been coded to not expect the merged contents to be present. Fix the test to check for the right behavior, and record how the different merge backends will be expected to handle it. Signed-off-by: Elijah Newren <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent ef52778 commit 489c85f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

t/t6416-recursive-corner-cases.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -786,7 +786,7 @@ test_expect_success 'merge of D1 & E3 succeeds' '
786786
)
787787
'
788788

789-
test_expect_success 'merge of D1 & E4 notifies user a and a2 are related' '
789+
test_expect_merge_algorithm failure success 'merge of D1 & E4 puts merge of a and a2 in both a and a2' '
790790
test_when_finished "git -C directory-file reset --hard" &&
791791
test_when_finished "git -C directory-file clean -fdqx" &&
792792
(
@@ -804,7 +804,7 @@ test_expect_success 'merge of D1 & E4 notifies user a and a2 are related' '
804804
test_line_count = 1 out &&
805805
806806
git rev-parse >expect \
807-
A:ignore-me B:a D1:a E4:a2 &&
807+
A:ignore-me B:a E4:a2 E4:a2 &&
808808
git rev-parse >actual \
809809
:0:ignore-me :1:a~Temporary\ merge\ branch\ 2 :2:a :3:a2 &&
810810
test_cmp expect actual

0 commit comments

Comments
 (0)