Skip to content

Commit 48f1e49

Browse files
committed
Merge branch 'mh/for-each-string-list-item-empty-fix'
Code cmp.std.c nitpick. * mh/for-each-string-list-item-empty-fix: for_each_string_list_item: avoid undefined behavior for empty list
2 parents 6b05e61 + ac7da78 commit 48f1e49

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

string-list.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,10 @@ void string_list_clear_func(struct string_list *list, string_list_clear_func_t c
3232
typedef int (*string_list_each_func_t)(struct string_list_item *, void *);
3333
int for_each_string_list(struct string_list *list,
3434
string_list_each_func_t, void *cb_data);
35-
#define for_each_string_list_item(item,list) \
36-
for (item = (list)->items; item < (list)->items + (list)->nr; ++item)
35+
#define for_each_string_list_item(item,list) \
36+
for (item = (list)->items; \
37+
item && item < (list)->items + (list)->nr; \
38+
++item)
3739

3840
/*
3941
* Apply want to each item in list, retaining only the ones for which

0 commit comments

Comments
 (0)