Skip to content

Commit 4ca9453

Browse files
Ramsay Jonesgitster
authored andcommitted
t7810-*.sh: Remove redundant test
Since commit bbc09c2 ("grep: rip out support for external grep", 12-01-2010), test number 60 ("grep -C1 hunk mark between files") is essentially the same as test number 59. Test 59 was intended to verify the behaviour of git-grep resulting from multiple invocations of an external grep. As part of the test, it creates and adds 1024 files to the index, which is now wasted effort. Remove test 59, since it is now redundant. Signed-off-by: Ramsay Jones <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent d0f1ea6 commit 4ca9453

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

t/t7810-grep.sh

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -387,17 +387,6 @@ test_expect_success 'grep -q, silently report matches' '
387387
test_cmp empty actual
388388
'
389389

390-
# Create 1024 file names that sort between "y" and "z" to make sure
391-
# the two files are handled by different calls to an external grep.
392-
# This depends on MAXARGS in builtin-grep.c being 1024 or less.
393-
c32="0 1 2 3 4 5 6 7 8 9 a b c d e f g h i j k l m n o p q r s t u v"
394-
test_expect_success 'grep -C1, hunk mark between files' '
395-
for a in $c32; do for b in $c32; do : >y-$a$b; done; done &&
396-
git add y-?? &&
397-
git grep -C1 "^[yz]" >actual &&
398-
test_cmp expected actual
399-
'
400-
401390
test_expect_success 'grep -C1 hunk mark between files' '
402391
git grep -C1 "^[yz]" >actual &&
403392
test_cmp expected actual

0 commit comments

Comments
 (0)