Skip to content

Commit 5094d15

Browse files
jrngitster
authored andcommitted
t4034 (diff --word-diff): style suggestions
Rearrange code to be easier to browse: - first data - then functions - then test assertions Mark up inline test vectors as cat >vector <<-\EOF data data EOF for visual scannability. Use words like "set up" for tests that set up for other tests, to make it obvious which tests are safe to skip. Use repeated function calls instead of a loop for the language-specific tests, so the invocations can be easily tweaked individually (for example if one starts to fail). This means if you add a new subdirectory to t4034/, it will not be automatically used. I think that's worth it for the added explicitness. Signed-off-by: Jonathan Nieder <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 664d44e commit 5094d15

File tree

1 file changed

+205
-245
lines changed

1 file changed

+205
-245
lines changed

0 commit comments

Comments
 (0)