Skip to content

Commit 5220b75

Browse files
committed
Merge branch 'lc/shell-default-value-noexpand' into maint
Fix unnecessarily waste in the idiomatic use of ': ${VAR=default}' to set the default value, without enclosing it in double quotes. * lc/shell-default-value-noexpand: sh-setup: enclose setting of ${VAR=default} in double-quotes
2 parents 1a88ca9 + 01247e0 commit 5220b75

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

git-sh-setup.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,8 @@ git_pager() {
160160
else
161161
GIT_PAGER=cat
162162
fi
163-
: ${LESS=-FRX}
164-
: ${LV=-c}
163+
: "${LESS=-FRX}"
164+
: "${LV=-c}"
165165
export LESS LV
166166
167167
eval "$GIT_PAGER" '"$@"'
@@ -344,7 +344,7 @@ git_dir_init () {
344344
echo >&2 "Unable to determine absolute path of git directory"
345345
exit 1
346346
}
347-
: ${GIT_OBJECT_DIRECTORY="$(git rev-parse --git-path objects)"}
347+
: "${GIT_OBJECT_DIRECTORY="$(git rev-parse --git-path objects)"}"
348348
}
349349
350350
if test -z "$NONGIT_OK"

0 commit comments

Comments
 (0)