Skip to content

Commit 52c02f6

Browse files
jrngitster
authored andcommitted
pager test: make fake pager consume all its input
Otherwise there is a race: if 'git log' finishes writing before the pager terminates and closes the pipe, all is well, and if the pager finishes quickly enough then 'git log' terminates with SIGPIPE. died of signal 13 at /build/buildd/git-1.9~rc1/t/test-terminal.perl line 33. not ok 6 - LESS and LV envvars are set for pagination Noticed on Ubuntu PPA builders, where the race was lost about half the time. Compare v1.7.0.2~6^2 (tests: Fix race condition in t7006-pager, 2010-02-22). Reported-by: Anders Kaseorg <[email protected]> Signed-off-by: Jonathan Nieder <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent e54c1f2 commit 52c02f6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/t7006-pager.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ test_expect_failure TTY 'pager runs from subdir' '
4040
test_expect_success TTY 'LESS and LV envvars are set for pagination' '
4141
(
4242
sane_unset LESS LV &&
43-
PAGER="env >pager-env.out" &&
43+
PAGER="env >pager-env.out; wc" &&
4444
export PAGER &&
4545
4646
test_terminal git log

0 commit comments

Comments
 (0)