Skip to content

Commit 53b22a9

Browse files
committed
Merge branch 'maint-1.5.4' into maint-1.5.5
* maint-1.5.4: GIT 1.5.4.6 git-shell: accept "git foo" form Conflicts: GIT-VERSION-GEN RelNotes
2 parents 4afbcab + 872354d commit 53b22a9

File tree

2 files changed

+56
-4
lines changed

2 files changed

+56
-4
lines changed

Documentation/RelNotes-1.5.4.6.txt

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
GIT v1.5.4.6 Release Notes
2+
==========================
3+
4+
I personally do not think there is any reason anybody should want to
5+
run v1.5.4.X series these days, because 'master' version is always
6+
more stable than any tagged released version of git.
7+
8+
This is primarily to futureproof "git-shell" to accept requests
9+
without a dash between "git" and subcommand name (e.g. "git
10+
upload-pack") which the newer client will start to make sometime in
11+
the future.
12+
13+
Fixes since v1.5.4.5
14+
--------------------
15+
16+
* Command line option "-n" to "git-repack" was not correctly parsed.
17+
18+
* Error messages from "git-apply" when the patchfile cannot be opened
19+
have been improved.
20+
21+
* Error messages from "git-bisect" when given nonsense revisions have
22+
been improved.
23+
24+
* reflog syntax that uses time e.g. "HEAD@{10 seconds ago}:path" did not
25+
stop parsing at the closing "}".
26+
27+
* "git rev-parse --symbolic-full-name ^master^2" printed solitary "^",
28+
but it should print nothing.
29+
30+
* "git apply" did not enforce "match at the beginning" correctly.
31+
32+
* a path specification "a/b" in .gitattributes file should not match
33+
"sub/a/b", but it did.
34+
35+
* "git log --date-order --topo-order" did not override the earlier
36+
date-order with topo-order as expected.
37+
38+
* "git fast-export" did not export octopus merges correctly.
39+
40+
* "git archive --prefix=$path/" mishandled gitattributes.
41+
42+
As usual, it also comes with many documentation fixes and clarifications.
43+

shell.c

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ static int do_generic_cmd(const char *me, char *arg)
77
{
88
const char *my_argv[4];
99

10+
setup_path(NULL);
1011
if (!arg || !(arg = sq_dequote(arg)))
1112
die("bad argument");
1213
if (prefixcmp(me, "git-"))
@@ -29,7 +30,6 @@ static int do_cvs_cmd(const char *me, char *arg)
2930
die("git-cvsserver only handles server: %s", arg);
3031

3132
setup_path(NULL);
32-
3333
return execv_git_cmd(cvsserver_argv);
3434
}
3535

@@ -49,15 +49,24 @@ int main(int argc, char **argv)
4949
char *prog;
5050
struct commands *cmd;
5151

52+
/*
53+
* Special hack to pretend to be a CVS server
54+
*/
5255
if (argc == 2 && !strcmp(argv[1], "cvs server"))
5356
argv--;
54-
/* We want to see "-c cmd args", and nothing else */
57+
58+
/*
59+
* We do not accept anything but "-c" followed by "cmd arg",
60+
* where "cmd" is a very limited subset of git commands.
61+
*/
5562
else if (argc != 3 || strcmp(argv[1], "-c"))
5663
die("What do you think I am? A shell?");
5764

5865
prog = argv[2];
59-
argv += 2;
60-
argc -= 2;
66+
if (!strncmp(prog, "git", 3) && isspace(prog[3]))
67+
/* Accept "git foo" as if the caller said "git-foo". */
68+
prog[3] = '-';
69+
6170
for (cmd = cmd_list ; cmd->name ; cmd++) {
6271
int len = strlen(cmd->name);
6372
char *arg;

0 commit comments

Comments
 (0)